Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Definalize Amp\Socket\Server, or provide interfaces #66

Closed
ostrolucky opened this issue Aug 18, 2019 · 1 comment
Closed

Definalize Amp\Socket\Server, or provide interfaces #66

ostrolucky opened this issue Aug 18, 2019 · 1 comment
Labels
feature request

Comments

@ostrolucky
Copy link

Amp\Socket\Server was made final in release 1.0, which once again complicates my testing. I can no longer do $server->expects($this->exactly(1))->method('close');
@kelunik
Copy link
Member

kelunik commented Feb 22, 2022

Amp\Socket\SocketServer is now an interface in the upcoming v2 version.

@kelunik kelunik closed this as completed Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ostrolucky @kelunik