Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic: Jovu Phase 2 #8341

Merged
merged 48 commits into from May 2, 2024
Merged

Epic: Jovu Phase 2 #8341

merged 48 commits into from May 2, 2024

Conversation

yuval-hazaz
Copy link
Member

@yuval-hazaz yuval-hazaz commented Apr 28, 2024

Fixes: #8307

PR Details

Adds the plugins API client on amplication-server to make the catalog available for Jovu

PR Checklist

  • Tests for the changes have been added
  • npm test doesn't throw any error

IMPORTANT: Please review the CONTRIBUTING.md file for detailed contributing guidelines.

Copy link

nx-cloud bot commented Apr 28, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f4c739d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

@overbit overbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but it's missing unit tests. All these new services are missing them.

@yuval-hazaz yuval-hazaz changed the title Feat(server): add plugin catalog knowledge for Jovu Epic: Jovu Phase 2 May 1, 2024
@yuval-hazaz yuval-hazaz marked this pull request as draft May 1, 2024 08:35
@yuval-hazaz yuval-hazaz marked this pull request as ready for review May 2, 2024 13:56
@mulygottlieb mulygottlieb merged commit 90c0db3 into next May 2, 2024
14 checks passed
@mulygottlieb mulygottlieb deleted the feat/jovu-plugins branch May 2, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants