Add seo url for webm videos to circumvent a safari issue #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some versions of safari are unable to play webm videos if the url does not end in a
.webmextension. With videos served by amplience, this issue was partially present, as the video would fail to load normally, but if you had visited the video before and cached the 302, it would work (as the redirect target has the extension .webm).This PR adds a step after fetching set data where it enriches webm videos in the set to add an seo url, in the format
profile.webm. This seems to allow the video to load on safari without needing to visit and cache the 302 redirect.