Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: mutable defaults in init #48

Merged
merged 5 commits into from
Aug 3, 2023
Merged

fix: mutable defaults in init #48

merged 5 commits into from
Aug 3, 2023

Conversation

Mercy811
Copy link
Contributor

@Mercy811 Mercy811 commented Aug 3, 2023

Summary

Fix #45

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?:

@Mercy811 Mercy811 marked this pull request as ready for review August 3, 2023 17:21
@Mercy811 Mercy811 changed the title fix: multi instances api key should be different fix: mutable defaults in init Aug 3, 2023
@Mercy811 Mercy811 merged commit 958e394 into main Aug 3, 2023
8 checks passed
@Mercy811 Mercy811 deleted the AMP-76633-fix-multi-instances-api-key branch August 3, 2023 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuhao900914 yuhao900914 yuhao900914 approved these changes

@justin-fiedler justin-fiedler Awaiting requested review from justin-fiedler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Two different Amplitude instances send event to the same project
2 participants
@Mercy811 @yuhao900914