Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing confirmation message after posting comment #1792

Closed
swissspidy opened this issue Jan 2, 2019 · 2 comments
Closed

Missing confirmation message after posting comment #1792

swissspidy opened this issue Jan 2, 2019 · 2 comments
Labels
Bug Something isn't working

Comments

@swissspidy
Copy link
Collaborator

According to #1029 / #936 confirmation messages should be displayed when posting a comment. However, that doesn't seem to be the case (anymore).

To reproduce:

  1. Install AMP plugin
  2. Activate Twenty Nineteen or any other theme that works well in native or paired mode
  3. Enable comment moderation.
  4. Write and submit a comment.
  5. Note that the name & email fields are filled out, the textarea is emptied, and there is no confirmation message at all.
  6. See comment held for moderation in the admin

Screenshot:

screenshot 2019-01-02 at 16 21 39

@swissspidy swissspidy added the Bug Something isn't working label Jan 2, 2019
@westonruter
Copy link
Member

@swissspidy The message in question for #1029 / #936 only applies to when using <amp-live-list> for comments. That is, enabling the comments_live_list argument for amp theme support.

I believe that the issue you are noticing here would be reproducible without AMP entirely. I just tried in Twenty Seventeen in a non-AMP page and I saw the same thing.

I believe you are noticing a core bug, namely: https://core.trac.wordpress.org/ticket/43857

If you enable this setting in Discussion then you should see the classic moderation messages:

image

@swissspidy
Copy link
Collaborator Author

🤦‍♂️ Thank you! I'll close this then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants