Skip to content

Commit

Permalink
pr comments
Browse files Browse the repository at this point in the history
  • Loading branch information
kmh287 committed Apr 26, 2017
1 parent 68603c3 commit 030316e
Showing 1 changed file with 6 additions and 5 deletions.
11 changes: 6 additions & 5 deletions src/service/action-impl.js
Expand Up @@ -197,9 +197,9 @@ export class ActionService {
* @param {!Event} event A `change` event.
*/
addChangeDetails_(event) {
const detail = {};
const detail = map();
const target = event.target;
const tagName = event.target.tagName.toLowerCase();
const tagName = target.tagName.toLowerCase();
switch (tagName) {
case 'input':
const inputType = target.getAttribute('type');
Expand All @@ -216,14 +216,15 @@ export class ActionService {
detail[field] = String(value);
}
});
event.detail = detail;
}
break;
case 'select':
detail['value'] = target['value'];
event.detail = detail;
detail.value = target.value;
break;
}
if (Object.keys(detail).length > 0) {
event.detail = detail;
}
}

/**
Expand Down

0 comments on commit 030316e

Please sign in to comment.