amp-bind: Fix [class] verify bug (#8938)

* fix * unit tests
ampproject · Apr 25, 2017 · 15cdbd8 · 15cdbd8
1 parent 6038844
commit 15cdbd8
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/extensions/amp-bind/0.1/bind-impl.js b/extensions/amp-bind/0.1/bind-impl.js
@@ -773,7 +773,10 @@ export class Bind {
         if (Array.isArray(expectedValue)) {
           classes = expectedValue;
         } else if (typeof expectedValue === 'string') {
-          classes = expectedValue.split(' ');
+          const trimmed = expectedValue.trim();
+          if (trimmed.length > 0) {
+            classes = trimmed.split(' ');
+          }
         } else {
           const err = user().createError(
               `${TAG}: "${expectedValue}" is not a valid result for [class].`);

diff --git a/extensions/amp-bind/0.1/test/test-bind-impl.js b/extensions/amp-bind/0.1/test/test-bind-impl.js
@@ -194,7 +194,9 @@ describes.realWin('Bind', {
 
   it('should verify class bindings in dev mode', () => {
     window.AMP_MODE = {development: true};
-    createElementWithBinding(`[class]="'foo'" class="foo"`); // No error.
+    createElementWithBinding(`[class]="'foo'" class="foo"`);
+    createElementWithBinding(`[class]="'foo'" class=" foo "`);
+    createElementWithBinding(`[class]="''"`);
     createElementWithBinding(`[class]="'bar'" class="qux"`); // Error.
     const errorStub = env.sandbox.stub(user(), 'createError');
     return onBindReady().then(() => {