Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp-bind: Fix [class] verify bug #8938

Merged
merged 2 commits into from Apr 25, 2017

Conversation

dreamofabear
Copy link

Partial for #8933.

  • Verify empty string [class] correctly and ignore leading/trailing whitespaces.

/to @kmh287

William Chou added 2 commits April 25, 2017 13:09
@kmh287
Copy link
Contributor

kmh287 commented Apr 25, 2017

#8936

@dreamofabear
Copy link
Author

@kmh287 You're too fast. 😄 This PR also handles leading/trailing whitespace, e.g.

<p class="my-class" [class]="'my-class ' + myVar"></p>

Copy link
Contributor

@kmh287 kmh287 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair enough

@dreamofabear dreamofabear merged commit 15cdbd8 into ampproject:master Apr 25, 2017
mrjoro pushed a commit to mrjoro/amphtml that referenced this pull request Apr 28, 2017
KenneyE pushed a commit to spotxchange/amphtml that referenced this pull request May 3, 2017
@dreamofabear dreamofabear deleted the class-verify branch July 27, 2018 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants