Skip to content

Commit

Permalink
Amp analytics support taboola (#32803)
Browse files Browse the repository at this point in the history
* initial checkin for amp analytics support for taboola

* fixed commit of unnecessary changes

* Fix for PR comments. Reviewing the documentation, removed the transport section

* updated the URL to one hosted by taboola

* updated the URL to one hosted by taboola

* need image request only

* updated the name to be more descriptive

* Fix for unit tests
  • Loading branch information
udaya-m-taboola committed Mar 16, 2021
1 parent 4e5f655 commit 3b9a6dd
Show file tree
Hide file tree
Showing 4 changed files with 42 additions and 1 deletion.
15 changes: 14 additions & 1 deletion examples/analytics-vendors.amp.html
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@
<option>shinystat</option>
<option>snowplow</option>
<option>snowplow_v2</option>
<option>taboola</option>
<option>tail</option>
<option>teaanalytics</option>
<option>tealiumcollect</option>
Expand All @@ -135,7 +136,7 @@

<div id="container">
Container for analytics tags. Positioned far away from top to make sure that doesn't matter.

<!-- Acquia Lift example -->
<amp-analytics type="acquialift" id="acquialift">
<script type="application/json">
Expand Down Expand Up @@ -1652,6 +1653,18 @@
</amp-analytics>
<!-- End Snowplow Analytics example -->

<!-- Taboola Example
-->
<amp-analytics type="taboola" id="taboola">
<script type="application/json">
{
"vars": {
"aid": "1"
}
}
</script>
</amp-analytics>

<!-- Tail Analytics Example
Ensure you replace account with your account id.
-->
Expand Down
3 changes: 3 additions & 0 deletions extensions/amp-analytics/0.1/test/vendor-requests.json
Original file line number Diff line number Diff line change
Expand Up @@ -470,6 +470,9 @@
"selfDescribingEvent": "https://!collectorHost/i?p=web&tv=amp-1.0.2&e=ue&ue_pr=%7B%22schema%22%3A%22iglu%3Acom.snowplowanalytics.snowplow%2Funstruct_event%2Fjsonschema%2F1-0-0%22%2C%22data%22%3A%7B%22schema%22%3A%22iglu%3A!customEventSchemaVendor%2F!customEventSchemaName%2Fjsonschema%2F!customEventSchemaVersion%22%2C%22data%22%3A!customEventSchemaData%7D%7D&url=_ampdoc_url_&page=_title_&res=_screen_width_x_screen_height_&dtm=_timestamp_&tz=_timezone_code_&aid=!appId&cd=_screen_color_depth_&cs=_document_charset_&lang=_browser_language_&refr=_document_referrer_&vp=_viewport_width_x_viewport_height_&ua=_user_agent_&ds=_scroll_width_x_scroll_height_&uid=!userId&co=%7B%22schema%22%3A%22iglu%3Acom.snowplowanalytics.snowplow%2Fcontexts%2Fjsonschema%2F1-0-0%22%2C%22data%22%3A%5B%7B%22schema%22%3A%22iglu%3Adev.amp.snowplow%2Famp_id%2Fjsonschema%2F1-0-0%22%2C%22data%22%3A%7B%22ampClientId%22%3A%22_client_id(_sp_ampid)_%22%2C%20%22domainUserid%22%3A%20%22_if(_substr(_query_param(_sp)_%2C0%2C36)_%2C_substr(_query_param(_sp)_%2C0%2C36)_%2C_if(_linker_param(sp_amp_linker%2C_sp_duid)_%2C_linker_param(sp_amp_linker%2C_sp_duid)_%2C_cookie(_sp_duid)_)_)_%22%2C%20%22userId%22%3A%20%22!userId%22%7D%7D%2C_replace(!customContexts%2C%5E%2C*(.%2B%3F)%2C*%24%2C%241%2C)_%7B%22schema%22%3A%22iglu%3Adev.amp.snowplow%2Famp_web_page%2Fjsonschema%2F1-0-0%22%2C%22data%22%3A%7B%22ampPageViewId%22%3A%22_page_view_id_64_%22%7D%7D%5D%7D",
"ampPagePing": "https://!collectorHost/i?p=web&tv=amp-1.0.2&e=ue&ue_pr=%7B%22schema%22%3A%22iglu%3Acom.snowplowanalytics.snowplow%2Funstruct_event%2Fjsonschema%2F1-0-0%22%2C%22data%22%3A%7B%22schema%22%3A%22iglu%3Adev.amp.snowplow%2Famp_page_ping%2Fjsonschema%2F1-0-0%22%2C%22data%22%3A%7B%22scrollLeft%22%3A_scroll_left_%2C%22scrollWidth%22%3A_scroll_width_%2C%22viewportWidth%22%3A_viewport_width_%2C%22scrollTop%22%3A_scroll_top_%2C%22scrollHeight%22%3A_scroll_height_%2C%22viewportHeight%22%3A_viewport_height_%2C%22totalEngagedTime%22%3A_total_engaged_time_%7D%7D%7D&url=_ampdoc_url_&page=_title_&res=_screen_width_x_screen_height_&dtm=_timestamp_&tz=_timezone_code_&aid=!appId&cd=_screen_color_depth_&cs=_document_charset_&lang=_browser_language_&refr=_document_referrer_&vp=_viewport_width_x_viewport_height_&ua=_user_agent_&ds=_scroll_width_x_scroll_height_&uid=!userId&co=%7B%22schema%22%3A%22iglu%3Acom.snowplowanalytics.snowplow%2Fcontexts%2Fjsonschema%2F1-0-0%22%2C%22data%22%3A%5B%7B%22schema%22%3A%22iglu%3Adev.amp.snowplow%2Famp_id%2Fjsonschema%2F1-0-0%22%2C%22data%22%3A%7B%22ampClientId%22%3A%22_client_id(_sp_ampid)_%22%2C%20%22domainUserid%22%3A%20%22_if(_substr(_query_param(_sp)_%2C0%2C36)_%2C_substr(_query_param(_sp)_%2C0%2C36)_%2C_if(_linker_param(sp_amp_linker%2C_sp_duid)_%2C_linker_param(sp_amp_linker%2C_sp_duid)_%2C_cookie(_sp_duid)_)_)_%22%2C%20%22userId%22%3A%20%22!userId%22%7D%7D%2C_replace(!customContexts%2C%5E%2C*(.%2B%3F)%2C*%24%2C%241%2C)_%7B%22schema%22%3A%22iglu%3Adev.amp.snowplow%2Famp_web_page%2Fjsonschema%2F1-0-0%22%2C%22data%22%3A%7B%22ampPageViewId%22%3A%22_page_view_id_64_%22%7D%7D%5D%7D"
},
"taboola": {
"loadamptrkhtml": "https://c3.taboola.com/amp/amp-analytics-taboola.html?url=_canonical_url_&aid=!aid"
},
"tail": {
"host": "https://amp.t.tailtarget.com/amp/!account",
"domain": "https://amp.t.tailtarget.com/amp",
Expand Down
19 changes: 19 additions & 0 deletions extensions/amp-analytics/0.1/vendors/taboola.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
{
"vars": {
"aid": ""
},
"requests": {
"loadamptrkhtml": "https://c3.taboola.com/amp/amp-analytics-taboola.html?url=${canonicalUrl}&aid=${aid}"
},
"triggers": {
"pageview": {
"on": "visible",
"request": "loadamptrkhtml"
}
},
"transport": {
"beacon": false,
"xhrpost": false,
"image": true
}
}
6 changes: 6 additions & 0 deletions extensions/amp-analytics/analytics-vendors-list.md
Original file line number Diff line number Diff line change
Expand Up @@ -535,6 +535,12 @@ Type attribute value: `snowplow_v2`

Type attribute value: `subscriptions-propensity`

### Taboola

Type attribute value: `taboola`

Adds support for Taboola. More details for adding Taboola support can be found at [Taboola](https://taboola.com).

### Tail

Type attribute value: `tail`
Expand Down

0 comments on commit 3b9a6dd

Please sign in to comment.