Amp analytics support taboola #32803

udaya-m-taboola · 2021-02-22T18:34:57Z

No description provided.

calebcordry · 2021-02-22T18:40:40Z

micajuine-ho · 2021-02-22T19:03:34Z

extensions/amp-analytics/0.1/vendors/taboola.json

+  "transport": {
+    "beacon": false,
+    "xhrpost": false,
+    "image": true
+  }


amp-analytics handles defaulting from beacon => xhrpost => image. Just making sure that you want image requests to always be sent.

@micajuine-ho Reviewed the docs again. We dont need any overrides. So removed that section. Thanks

@micajuine-ho After testing I need the image GET request

micajuine-ho · 2021-02-22T19:14:54Z

extensions/amp-analytics/0.1/vendors/taboola.json

+    "pageview": {
+      "on": "visible",
+      "request": "url",
+      "iframePing": true


iframePing is used as a workaround for vendors transitioning to amp-analytics integration. Is this true for your case?

@micajuine-ho did not understand that. My bad. So removed that configuration.

…rt section

udaya-m-taboola · 2021-02-22T22:09:14Z

extensions/amp-analytics/0.1/test/vendor-requests.json

@@ -476,6 +476,9 @@
    "selfDescribingEvent": "https://!collectorHost/i?p=web&tv=amp-1.0.2&e=ue&ue_pr=%7B%22schema%22%3A%22iglu%3Acom.snowplowanalytics.snowplow%2Funstruct_event%2Fjsonschema%2F1-0-0%22%2C%22data%22%3A%7B%22schema%22%3A%22iglu%3A!customEventSchemaVendor%2F!customEventSchemaName%2Fjsonschema%2F!customEventSchemaVersion%22%2C%22data%22%3A!customEventSchemaData%7D%7D&url=_ampdoc_url_&page=_title_&res=_screen_width_x_screen_height_&dtm=_timestamp_&tz=_timezone_code_&aid=!appId&cd=_screen_color_depth_&cs=_document_charset_&lang=_browser_language_&refr=_document_referrer_&vp=_viewport_width_x_viewport_height_&ua=_user_agent_&ds=_scroll_width_x_scroll_height_&uid=!userId&co=%7B%22schema%22%3A%22iglu%3Acom.snowplowanalytics.snowplow%2Fcontexts%2Fjsonschema%2F1-0-0%22%2C%22data%22%3A%5B%7B%22schema%22%3A%22iglu%3Adev.amp.snowplow%2Famp_id%2Fjsonschema%2F1-0-0%22%2C%22data%22%3A%7B%22ampClientId%22%3A%22_client_id(_sp_ampid)_%22%2C%20%22domainUserid%22%3A%20%22_if(_substr(_query_param(_sp)_%2C0%2C36)_%2C_substr(_query_param(_sp)_%2C0%2C36)_%2C_if(_linker_param(sp_amp_linker%2C_sp_duid)_%2C_linker_param(sp_amp_linker%2C_sp_duid)_%2C_cookie(_sp_duid)_)_)_%22%2C%20%22userId%22%3A%20%22!userId%22%7D%7D%2C_replace(!customContexts%2C%5E%2C*(.%2B%3F)%2C*%24%2C%241%2C)_%7B%22schema%22%3A%22iglu%3Adev.amp.snowplow%2Famp_web_page%2Fjsonschema%2F1-0-0%22%2C%22data%22%3A%7B%22ampPageViewId%22%3A%22_page_view_id_64_%22%7D%7D%5D%7D",
    "ampPagePing": "https://!collectorHost/i?p=web&tv=amp-1.0.2&e=ue&ue_pr=%7B%22schema%22%3A%22iglu%3Acom.snowplowanalytics.snowplow%2Funstruct_event%2Fjsonschema%2F1-0-0%22%2C%22data%22%3A%7B%22schema%22%3A%22iglu%3Adev.amp.snowplow%2Famp_page_ping%2Fjsonschema%2F1-0-0%22%2C%22data%22%3A%7B%22scrollLeft%22%3A_scroll_left_%2C%22scrollWidth%22%3A_scroll_width_%2C%22viewportWidth%22%3A_viewport_width_%2C%22scrollTop%22%3A_scroll_top_%2C%22scrollHeight%22%3A_scroll_height_%2C%22viewportHeight%22%3A_viewport_height_%2C%22totalEngagedTime%22%3A_total_engaged_time_%7D%7D%7D&url=_ampdoc_url_&page=_title_&res=_screen_width_x_screen_height_&dtm=_timestamp_&tz=_timezone_code_&aid=!appId&cd=_screen_color_depth_&cs=_document_charset_&lang=_browser_language_&refr=_document_referrer_&vp=_viewport_width_x_viewport_height_&ua=_user_agent_&ds=_scroll_width_x_scroll_height_&uid=!userId&co=%7B%22schema%22%3A%22iglu%3Acom.snowplowanalytics.snowplow%2Fcontexts%2Fjsonschema%2F1-0-0%22%2C%22data%22%3A%5B%7B%22schema%22%3A%22iglu%3Adev.amp.snowplow%2Famp_id%2Fjsonschema%2F1-0-0%22%2C%22data%22%3A%7B%22ampClientId%22%3A%22_client_id(_sp_ampid)_%22%2C%20%22domainUserid%22%3A%20%22_if(_substr(_query_param(_sp)_%2C0%2C36)_%2C_substr(_query_param(_sp)_%2C0%2C36)_%2C_if(_linker_param(sp_amp_linker%2C_sp_duid)_%2C_linker_param(sp_amp_linker%2C_sp_duid)_%2C_cookie(_sp_duid)_)_)_%22%2C%20%22userId%22%3A%20%22!userId%22%7D%7D%2C_replace(!customContexts%2C%5E%2C*(.%2B%3F)%2C*%24%2C%241%2C)_%7B%22schema%22%3A%22iglu%3Adev.amp.snowplow%2Famp_web_page%2Fjsonschema%2F1-0-0%22%2C%22data%22%3A%7B%22ampPageViewId%22%3A%22_page_view_id_64_%22%7D%7D%5D%7D"
  },
+  "taboola": {
+    "url": "https://3p.ampproject.net/custom/amp-analytics-taboola.html?url=${canonicalUrl}&aid=${aid}"


@micajuine-ho I need this file https://3p.ampproject.net/custom/amp-analytics-taboola.html to be checked in or hosted at 3p.ampproject.net. Is there any documentation on how to do it ?

hi @micajuine-ho, what would you recommend us to do here ?

Why do you need it to be hosted on that URL rather than https://cdn.ampproject.org/v0/analytics-vendors/taboola.json?

@micajuine-ho part of the config in taboola.json is to load that html file which in turn loads our tracking javascript

Are you talking about this?

"requests": { "url": "https://3p.ampproject.net/custom/amp-analytics-taboola.html?url=${canonicalUrl}&aid=${aid}" },

@micajuine-ho Running it locally http://localhost:8000/examples/analytics-vendors.amp.html?type=taboola. The error shows up in console

As you can see, on that test page, the CORB error is occurring with all the vendors. If you isolate your analytics example by moving it to it's own test page, you won't see the error anymore.

@micajuine-ho yeah. I tested it on one of our publisher page and works fine. Thanks

@micajuine-ho what are the next steps for getting it merged ?

micajuine-ho · 2021-03-03T18:56:56Z

@udaya-m-taboola Please feel free to ping me on this thread if I don't respond in 1-2 days. Sometimes these things just slip through the cracks.

micajuine-ho · 2021-03-15T22:35:03Z

extensions/amp-analytics/0.1/vendors/taboola.json

+    "aid": ""
+  },
+  "requests": {
+    "url": "https://c3.taboola.com/amp/amp-analytics-taboola.html?url=${canonicalUrl}&aid=${aid}"


I would suggest you do a more descriptive request name than, url

Updated it to loadamptrkhtml instead

micajuine-ho · 2021-03-16T17:51:37Z

Please rebase.

micajuine-ho · 2021-03-16T19:39:45Z

Your unit tests are failing. Please fix before we can merge.

udaya-m-taboola · 2021-03-16T22:20:09Z

@micajuine-ho thanks for merging it. Usually what is the timeframe for it to go live ?

micajuine-ho · 2021-03-17T01:15:47Z

2 weeks. You can check on https://amp-release-calendar.appspot.com/

udaya-m-taboola added 2 commits February 22, 2021 10:19

initial checkin for amp analytics support for taboola

e05ee6f

fixed commit of unnecessary changes

a8cee39

amp-owners-bot bot requested a review from calebcordry February 22, 2021 18:35

calebcordry requested a review from micajuine-ho February 22, 2021 18:40

micajuine-ho reviewed Feb 22, 2021

View reviewed changes

Fix for PR comments. Reviewing the documentation, removed the transpo…

effb5d4

…rt section

udaya-m-taboola commented Feb 22, 2021

View reviewed changes

udaya-m-taboola added 3 commits March 15, 2021 08:38

updated the URL to one hosted by taboola

6ebb574

updated the URL to one hosted by taboola

fb5f9ba

need image request only

806d1de

micajuine-ho reviewed Mar 15, 2021

View reviewed changes

updated the name to be more descriptive

853136a

micajuine-ho approved these changes Mar 16, 2021

View reviewed changes

Merge branch 'master' into amp-analytics-support-taboola

a735d4e

Fix for unit tests

aebc380

micajuine-ho merged commit 3b9a6dd into ampproject:master Mar 16, 2021

ampprojectbot added PR use: In Beta / Experimental PR use: In Stable labels Mar 24, 2021

ampprojectbot added the PR use: In LTS label Apr 12, 2021

This was referenced Apr 25, 2021

🐛 Fix issue in taboola.json where the iframePing needs to be setup #34004

Closed

🐛 added support for iframePing to load trk.js #34007

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Amp analytics support taboola #32803

Amp analytics support taboola #32803

udaya-m-taboola commented Feb 22, 2021

calebcordry commented Feb 22, 2021

micajuine-ho Feb 22, 2021

udaya-m-taboola Feb 22, 2021

udaya-m-taboola Mar 15, 2021

micajuine-ho Feb 22, 2021

udaya-m-taboola Feb 22, 2021

udaya-m-taboola Feb 22, 2021

udaya-m-taboola Feb 23, 2021

micajuine-ho Mar 3, 2021 •

edited

udaya-m-taboola Mar 3, 2021

micajuine-ho Mar 3, 2021

udaya-m-taboola Mar 15, 2021 •

edited

micajuine-ho Mar 15, 2021

micajuine-ho Mar 15, 2021

udaya-m-taboola Mar 15, 2021

udaya-m-taboola Mar 15, 2021

micajuine-ho commented Mar 3, 2021

micajuine-ho Mar 15, 2021

udaya-m-taboola Mar 15, 2021

micajuine-ho commented Mar 16, 2021

micajuine-ho commented Mar 16, 2021

udaya-m-taboola commented Mar 16, 2021

micajuine-ho commented Mar 17, 2021

Amp analytics support taboola #32803

Amp analytics support taboola #32803

Conversation

udaya-m-taboola commented Feb 22, 2021

calebcordry commented Feb 22, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

micajuine-ho Mar 3, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

udaya-m-taboola Mar 15, 2021 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

micajuine-ho commented Mar 3, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

micajuine-ho commented Mar 16, 2021

micajuine-ho commented Mar 16, 2021

udaya-m-taboola commented Mar 16, 2021

micajuine-ho commented Mar 17, 2021

micajuine-ho Mar 3, 2021 •

edited

udaya-m-taboola Mar 15, 2021 •

edited