Skip to content

Commit

Permalink
Remove dead links in amp-access-analytics doc (#19588)
Browse files Browse the repository at this point in the history
* Remove dead links in amp-access-analytics doc

Remove links to ./amp-access-spec.md#login-page.  The related content has not yet been added to the Detailed Discussion section of amp-access.md.

* Fix link to amp-var-substitutions doc

Add missing double-dot notation to relative link.  The link was failing a Travis CI test.
  • Loading branch information
Patrick Roche authored and Dima Voytenko committed Dec 10, 2018
1 parent 0a9478b commit 3e0e9d8
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions extensions/amp-access/amp-access-analytics.md
Expand Up @@ -91,7 +91,7 @@ The `access-pingback-failed` event is issued when the Pingback endpoint has fail

The `access-login[-type]-started` event is issued right before the Login dialog has been opened. Use these configurations to fire a request for this event.

When only one Login URL is configured, the event is `access-login-started`. When multiple Login URLs are configured, the event is `access-login-type-started`, e.g. "access-login-signup-started". See [Login Page Spec](./amp-access-spec.md#login-page) for more info.
When only one Login URL is configured, the event is `access-login-started`. When multiple Login URLs are configured, the event is `access-login-type-started`, e.g. "access-login-signup-started".

```javascript
"triggers": {
Expand All @@ -106,7 +106,7 @@ When only one Login URL is configured, the event is `access-login-started`. When

The `access-login[-type]-success` event is issued when Login dialog has succeeded. Use these configurations to fire a request for this event.

When only one Login URL is configured, the event is `access-login-success`. When multiple Login URLs are configured, the event is `access-login-type-success`, e.g. "access-login-signup-success". See [Login Page Spec](./amp-access-spec.md#login-page) for more info.
When only one Login URL is configured, the event is `access-login-success`. When multiple Login URLs are configured, the event is `access-login-type-success`, e.g. "access-login-signup-success".

```javascript
"triggers": {
Expand All @@ -121,7 +121,7 @@ When only one Login URL is configured, the event is `access-login-success`. When

The `access-login[-type]-rejected` event is issued when Login dialog has been rejected by the user. Use these configurations to fire a request for this event.

When only one Login URL is configured, the event is `access-login-rejected`. When multiple Login URLs are configured, the event is `access-login-type-rejected`, e.g. "access-login-signup-rejected". See [Login Page Spec](./amp-access-spec.md#login-page) for more info.
When only one Login URL is configured, the event is `access-login-rejected`. When multiple Login URLs are configured, the event is `access-login-type-rejected`, e.g. "access-login-signup-rejected".

```javascript
"triggers": {
Expand All @@ -136,7 +136,7 @@ When only one Login URL is configured, the event is `access-login-rejected`. Whe

The `access-login[-type]-failed` event is issued when Login dialog has failed due to an unknown reason. Use these configurations to fire a request for this event.

When only one Login URL is configured, the event is `access-login[-type]-failed`. When multiple Login URLs are configured, the event is `access-login-type-failed`, e.g. "access-login-signup-failed". See [Login Page Spec](./amp-access-spec.md#login-page) for more info.
When only one Login URL is configured, the event is `access-login[-type]-failed`. When multiple Login URLs are configured, the event is `access-login-type-failed`, e.g. "access-login-signup-failed".

```javascript
"triggers": {
Expand All @@ -149,7 +149,7 @@ When only one Login URL is configured, the event is `access-login[-type]-failed`

## Access analytics variables

Access contributes the following URL substitutions to the [amp-var-substitutions.md](/spec/amp-var-substitutions.md).
Access contributes the following URL substitutions to the [amp-var-substitutions.md](../../spec/amp-var-substitutions.md).

### ACCESS_READER_ID

Expand Down

0 comments on commit 3e0e9d8

Please sign in to comment.