Remove dead links in amp-access-analytics doc #19588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Triaging to @jridgewell as you were last in the commit history 😄 Also, @plr108 Thank you very much for finding/fixing this! For future reference, could you remove the PR/Issue template when you submit the PR? It is there more for a guide than to keep in the PR. Either way, great work, and thanks again for the help! 👍 |
|
This goes to @dvoytenko. |
jridgewell
requested review from
dvoytenko
and removed request for
jridgewell
|
Thanks @torch2424! I removed the template as I needed to bring this pull request up to date with master anyway. |
dvoytenko
approved these changes
Dec 7, 2018
|
LGTM on these changes, but it looks like Travis is still failing? |
|
Yes I will try to bring my branch up to date with master (plus the doc
change) a little later today.
…On Fri, Dec 7, 2018 at 12:46 PM Dima Voytenko ***@***.***> wrote:
LGTM on these changes, but it looks like Travis is still failing?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#19588 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKt0ql6KD1iM60zClaxvktLSgHOh6X7qks5u2qlZgaJpZM4Y_Q0s>
.
|
plr108-zz
force-pushed
the
amp-access-analytics-doc
branch
3 times, most recently
from
a2503cb
to
d3cf48d
Compare
added 2 commits
December 10, 2018 10:47
Remove links to ./amp-access-spec.md#login-page. The related content has not yet been added to the Detailed Discussion section of amp-access.md.
Add missing double-dot notation to relative link. The link was failing a Travis CI test.
plr108-zz
force-pushed
the
amp-access-analytics-doc
branch
from
d3cf48d
to
a8e7ab2
Compare
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* Remove dead links in amp-access-analytics doc Remove links to ./amp-access-spec.md#login-page. The related content has not yet been added to the Detailed Discussion section of amp-access.md. * Fix link to amp-var-substitutions doc Add missing double-dot notation to relative link. The link was failing a Travis CI test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove links to ./amp-access-spec.md#login-page. The related content has not yet been added to the Detailed Discussion section of amp-access.md.