Skip tests failing on SL Chrome 71 (#19722)

ampproject · Dec 7, 2018 · 5807c73 · 5807c73
1 parent ac96f9d
commit 5807c73
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 9 deletions.
diff --git a/extensions/amp-form/0.1/test/integration/test-integration-form-verifiers.js b/extensions/amp-form/0.1/test/integration/test-integration-form-verifiers.js
@@ -22,7 +22,8 @@ const RENDER_TIMEOUT = 15000;
 const describeChrome =
     describe.configure().ifNewChrome().skipSinglePass();
 
-describeChrome.run('amp-form verifiers', function() {
+// TODO(cvializ, #19647): Broken on SL Chrome 71.
+describeChrome.skip('amp-form verifiers', function() {
   this.timeout(RENDER_TIMEOUT);
 
   describes.integration('verify-error template', {

diff --git a/extensions/amp-form/0.1/test/integration/test-integration-form.js b/extensions/amp-form/0.1/test/integration/test-integration-form.js
@@ -163,7 +163,8 @@ describes.realWin('AmpForm Integration', {
     });
   });
 
-  describeChrome.run('Submit xhr-POST', function() {
+  // TODO(cvializ, #19647): Broken on SL Chrome 71.
+  describeChrome.skip('Submit xhr-POST', function() {
     this.timeout(RENDER_TIMEOUT);
 
     it('should submit and render success', () => {
@@ -227,7 +228,8 @@ describes.realWin('AmpForm Integration', {
     });
   });
 
-  describeChrome.run('Submit xhr-GET', function() {
+  // TODO(cvializ, #19647): Broken on SL Chrome 71.
+  describeChrome.skip('Submit xhr-GET', function() {
     this.timeout(RENDER_TIMEOUT);
 
     it('should submit and render success', () => {
@@ -293,7 +295,8 @@ describes.realWin('AmpForm Integration', {
     });
   });
 
-  describeChrome.run('Submit result message', () => {
+  // TODO(cvializ, #19647): Broken on SL Chrome 71.
+  describeChrome.skip('Submit result message', () => {
     it('should render messages with or without a template', () => {
       // Stubbing timeout to catch async-thrown errors and expect
       // them. These catch errors thrown inside the catch-clause of the

diff --git a/test/integration/test-amp-bind.js b/test/integration/test-amp-bind.js
@@ -79,7 +79,8 @@ describe.configure().ifNewChrome().run('amp-bind', function() {
     return fixture.awaitEvent(BindEvents.RESCAN_TEMPLATE, ++numTemplated);
   }
 
-  describe('with [text] and [class]', () => {
+  // TODO(choumx, #19647): Times out on SL Chrome 71.
+  describe.skip('with [text] and [class]', () => {
     beforeEach(() => {
       return setupWithFixture('test/fixtures/bind-basic.html');
     });
@@ -107,7 +108,8 @@ describe.configure().ifNewChrome().run('amp-bind', function() {
 
   // TODO(choumx, #9759): Seems like old browsers give up when hitting
   // expected user errors due to illegal bindings in the form's template.
-  describe.configure().ifChrome().run('with <amp-form>', () => {
+  // TODO(choumx, #19647): Times out on SL Chrome 71.
+  describe.configure().ifChrome().skip('with <amp-form>', () => {
     beforeEach(() => {
       // <form> is not an AMP element.
       return setupWithFixture('test/fixtures/bind-form.html', 0)
@@ -548,7 +550,8 @@ describe.configure().ifNewChrome().run('amp-bind', function() {
     });
   });
 
-  describe('with <amp-list>', () => {
+  // TODO(choumx, #19647): Times out on SL Chrome 71.
+  describe.skip('with <amp-list>', () => {
     beforeEach(() => {
       return setupWithFixture('test/fixtures/bind-list.html', 1);
     });

diff --git a/test/integration/test-amp-pixel.js b/test/integration/test-amp-pixel.js
@@ -20,8 +20,6 @@ import {Services} from '../../src/services';
 import {createElementWithAttributes} from '../../src/dom';
 
 describe.configure().skipIfPropertiesObfuscated().run('amp-pixel', function() {
-  this.timeout(1000);
-
   describes.integration('amp-pixel macro integration test', {
     body: `<amp-pixel
     src="${RequestBank.getUrl()}hello-world?title=TITLE&qp=QUERY_PARAM(a)">`,