Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip tests failing on SL Chrome 71 #19722

Merged

Conversation

dreamofabear
Copy link

Temporary relief for #19647.

@rsimha
Copy link
Contributor

rsimha commented Dec 7, 2018

Seems like there are 4 more failures: https://travis-ci.org/ampproject/amphtml/jobs/465047006#L698

@lannka
Copy link
Contributor

lannka commented Dec 7, 2018

I send a PR to see if the amp-pixel tests could be fixed: #19723

@dreamofabear
Copy link
Author

[18:56:09] Safari 11.1.2 (Mac OS X 10.13.6): Executed 91 of 485 (Skipped 394) 2 FAILED
...
[18:57:07] Edge 17.17134.0 (Windows 10 0.0.0): Executed 90 of 485 (Skipped 395) 3 FAILED
...
[19:00:05] Chrome 71.0.3578 (Windows 10 0.0.0): Executed 313 of 485 (Skipped 169) 1 FAILED

@lannka
Copy link
Contributor

lannka commented Dec 7, 2018

@choumx very close! one more failure

DESCRIBE => amp-bind
  DESCRIBE => with [text] and [class]
    IT => "before each" hook for "should update CSS class when class binding changes"
      ✗ Error: Timeout waiting for All AMP components are laid out
          at poll (home/travis/build/ampproject/amphtml/testing/iframe.js:423:18)

@alanorozco alanorozco merged commit 5807c73 into ampproject:master Dec 7, 2018
@dreamofabear dreamofabear deleted the skip-sl-chrome-71-failures branch December 7, 2018 20:41
noranazmy pushed a commit to noranazmy/amphtml that referenced this pull request Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants