Skip to content

Commit

Permalink
Remove all .max usage in doc #9931 (#10133)
Browse files Browse the repository at this point in the history
  • Loading branch information
anantoghosh authored and zhouyx committed Jun 27, 2017
1 parent 30cb97b commit 743b137
Show file tree
Hide file tree
Showing 8 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion ads/README.md
Expand Up @@ -248,7 +248,7 @@ If you're adding support for a new 3P ad service, changes to the following files

### Verify your examples

To verify the examples that you have put in `/examples/ads.amp.html`, you will need to start a local gulp web server by running command `gulp`. Then visit `http://localhost:8000/examples/ads.amp.max.html?type=yournetwork` in your browser to make sure the examples load ads.
To verify the examples that you have put in `/examples/ads.amp.html`, you will need to start a local gulp web server by running command `gulp`. Then visit `http://localhost:8000/examples/ads.amp.html?type=yournetwork` in your browser to make sure the examples load ads.

Please consider having the example consistently load a fake ad (with ad targeting disabled). Not only it will be a more confident example for publishers to follow, but also for us to catch any regression bug during our releases.

Expand Down
4 changes: 2 additions & 2 deletions build-system/app.js
Expand Up @@ -747,15 +747,15 @@ function elementExtractor(tagName, type) {
'gm');
}

// Data for example: http://localhost:8000/examples/bind/xhr.amp.max.html
// Data for example: http://localhost:8000/examples/bind/xhr.amp.html
app.use('/bind/form/get', (req, res) => {
assertCors(req, res, ['GET']);
res.json({
bindXhrResult: 'I was fetched from the server!',
});
});

// Data for example: http://localhost:8000/examples/bind/ecommerce.amp.max.html
// Data for example: http://localhost:8000/examples/bind/ecommerce.amp.html
app.use('/bind/ecommerce/sizes', (req, res) => {
assertCors(req, res, ['GET']);
setTimeout(() => {
Expand Down
2 changes: 1 addition & 1 deletion build-system/tasks/make-golden.js
Expand Up @@ -67,7 +67,7 @@ function doScreenshot(host, path, output, device, verbose, cb) {
/**
* Make a golden image of the url.
* Ex:
* `gulp make-golden --path=examples/everything.amp.max.html \
* `gulp make-golden --path=examples/everything.amp.html \
* --host=http://localhost:8000`
* @param {function} cb callback function
*/
Expand Down
2 changes: 1 addition & 1 deletion examples/ads-legacy.amp.html
Expand Up @@ -335,7 +335,7 @@ <h2>OpenX</h2>
data-nc="90577858-BidderTest">
</amp-ad>
<div>
<a href="openx.amp.max.html">See all OpenX examples</a>
<a href="openx.amp.html">See all OpenX examples</a>
</div>

<h2>SmartAdServer ad</h2>
Expand Down
2 changes: 1 addition & 1 deletion examples/ads.amp.html
Expand Up @@ -959,7 +959,7 @@ <h2>OpenX</h2>
data-nc="90577858-BidderTest">
</amp-ad>
<div>
<a href="openx.amp.max.html">See all OpenX examples</a>
<a href="openx.amp.html">See all OpenX examples</a>
</div>

<h2>Outbrain widget</h2>
Expand Down
6 changes: 3 additions & 3 deletions test/functional/test-extension-location.js
Expand Up @@ -48,7 +48,7 @@ describes.sandboxed('Extension Location', {}, () => {
it('with remote mode', () => {
window.AMP_MODE = {rtvVersion: '123'};
const script = calculateExtensionScriptUrl({
pathname: 'examples/ads.amp.min.html',
pathname: 'examples/ads.amp.html',
host: 'localhost:8000',
protocol: 'http:',
}, 'amp-ad', false);
Expand Down Expand Up @@ -79,7 +79,7 @@ describes.sandboxed('Extension Location', {}, () => {
it('with remote mode', () => {
window.AMP_MODE = {rtvVersion: '123'};
const script = calculateEntryPointScriptUrl({
pathname: 'examples/ads.amp.min.html',
pathname: 'examples/ads.amp.html',
host: 'localhost:8000',
protocol: 'http:',
}, 'sw', /* isLocalDev */ false);
Expand All @@ -90,7 +90,7 @@ describes.sandboxed('Extension Location', {}, () => {
it('with remote mode & rtv', () => {
window.AMP_MODE = {rtvVersion: '123'};
const script = calculateEntryPointScriptUrl({
pathname: 'examples/ads.amp.min.html',
pathname: 'examples/ads.amp.html',
host: 'localhost:8000',
protocol: 'http:',
}, 'ww', /* isLocalDev */ false, /* opt_rtv */ true);
Expand Down
2 changes: 1 addition & 1 deletion test/manual/pre-render-load.html
@@ -1 +1 @@
<iframe src="/examples/article.amp.max.html#prerenderSize=1&visibilityState=prerender&viewerorigin=http://localhost:8000&log=4" width="100%" height=100%></iframe>
<iframe src="/examples/article.amp.html#prerenderSize=1&visibilityState=prerender&viewerorigin=http://localhost:8000&log=4" width="100%" height=100%></iframe>
2 changes: 1 addition & 1 deletion testing/screenshots/make-screenshot.js
Expand Up @@ -24,7 +24,7 @@
* ```
* phantomjs --ssl-protocol=any --ignore-ssl-errors=true --load-images=true \
* make-screenshot.js "http://localhost:8000" \
* "/examples/everything.amp.max.html" \
* "/examples/everything.amp.html" \
* "everything.png" "iPhone6+"
* ```
*/
Expand Down

0 comments on commit 743b137

Please sign in to comment.