Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all .max usage in doc #9931

Closed
zhouyx opened this issue Jun 14, 2017 · 8 comments
Closed

Remove all .max usage in doc #9931

zhouyx opened this issue Jun 14, 2017 · 8 comments

Comments

@zhouyx
Copy link
Contributor

zhouyx commented Jun 14, 2017

Description

.max.html and .min.html usage has been deprecated. However we fail to update them everywhere in our documentation and comment

Ref PR: #8559

The Fix

  • Search for .max.html in our code base.
  • Find deprecated usage of localhost:8000/examples/***.max.html and rename them to end with .html
  • Submit for review!

Once approved, your changes will be merged. ⚡⚡⚡Congrats on making your first contribution to the AMP Project!⚡⚡⚡ You'll be able to see it live across the web soon!

Thanks, and we hope to see more contributions from you soon.

Questions?

If you have questions ask in this issue or on your Pull Request see the How to get help section of the Getting Started guide.

@anantoghosh
Copy link
Contributor

I would like to work on this! @zhouyx

@zhouyx
Copy link
Contributor Author

zhouyx commented Jun 22, 2017

@anantoghosh Great!!! Please consider join the AMP Project on GitHub so we can assign this issue to you 😄

Let me know if any help is needed!

@anantoghosh
Copy link
Contributor

@zhouyx joined.

@zhouyx
Copy link
Contributor Author

zhouyx commented Jun 22, 2017

Thanks! Assigned the issue to you 😄

anantoghosh added a commit to anantoghosh/amphtml that referenced this issue Jun 22, 2017
anantoghosh added a commit to anantoghosh/amphtml that referenced this issue Jun 23, 2017
@anantoghosh
Copy link
Contributor

@zhouyx I need a little help.
Trying to commit ads/README.md runs gulp check-links on the file which is failing
https://travis-ci.org/ampproject/amphtml/jobs/245967540

Starting 'check-links'...
[14:39:32] [✖] http://rawgit.com/slightlyoff/IntersectionObserver/master/index.html#intersectionobserverentry
[14:39:32] [✖] https://github.com/ampproject/amphtml/blob/master/src/3p.js
[14:39:33] [✖] https://sub-domain.nytimes.com
[14:39:34] [✖] ../CONTRIBUTIONG.md#contributing-code
[14:39:34] ERROR Possible dead link(s) found in ads/README.md (please update, or whitelist in build-system/tasks/ch
eck-links.js).
[14:39:34] ERROR Possible dead link(s) found in this PR. Please update ads/README.md or whitelist in build-system/t
asks/check-links.js

These links are separate and not related to my commit.
Should I leave this file?

@anantoghosh
Copy link
Contributor

I have created a pr fixing the links ads/README.md #10124

@zhouyx
Copy link
Contributor Author

zhouyx commented Jun 23, 2017

@anantoghosh Thanks for fixing our readme bug while working on this GFI !!! 👍 🎉 🎉

@zhouyx
Copy link
Contributor Author

zhouyx commented Jun 27, 2017

Thanks @anantoghosh ! 🎉 🎉 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants