Skip to content

Commit

Permalink
✅ Fix amp-ad-3p sourceUrl assertion for IE11 (#30389)
Browse files Browse the repository at this point in the history
* Fix amp-ad-3p sourceUrl assertion for IE11

* Swap back-slash for forward-slash

* %s/isIE/isIe/
  • Loading branch information
rcebulko committed Sep 24, 2020
1 parent 011dd32 commit 7870242
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions test/integration/test-amp-ad-3p.js
Original file line number Diff line number Diff line change
Expand Up @@ -125,11 +125,11 @@ describe('amp-ad 3P', () => {
);
}
expect(context.startTime).to.be.a('number');
// Edge has different opinion about window.location in srcdoc iframe.
// Edge/IE has different opinion about window.location in srcdoc iframe.
// Nevertheless this only happens in test. In real world AMP will not
// in srcdoc iframe.
expect(context.sourceUrl).to.equal(
platform.isEdge()
platform.isEdge() || platform.isIe()
? 'http://localhost:9876/context.html'
: 'about:srcdoc'
);
Expand Down

0 comments on commit 7870242

Please sign in to comment.