✅ Fix amp-ad-3p sourceUrl assertion for IE11 #30389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhouyx
approved these changes
Sep 24, 2020
This was referenced Sep 24, 2020
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
* Fix amp-ad-3p sourceUrl assertion for IE11 * Swap back-slash for forward-slash * %s/isIE/isIe/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
window.locationin a srcdoc iframe is"about:srcdoc"in sane browsers and a special magic string in Edge and IE. The special-case handling was in place already for Edge, but not for IE, causing the IE11 integration test to fail. This PR adds the IE11 check to the special-case check.Part of broad effort under #28152 to enable IE11 integration tests as blocking