Support the data-language attribute for AdSense (#12300)

* Support the data-language attribute for AdSense * Updated AdSense documentation. * Address review comment
ampproject · Dec 5, 2017 · 8355bc6 · 8355bc6
1 parent 2b16d73
commit 8355bc6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 0 deletions.
diff --git a/ads/google/adsense.md b/ads/google/adsense.md
@@ -37,3 +37,4 @@ Supported parameters:
 - data-ad-host
 - data-adtest
 - data-tag-origin
+- data-language
diff --git a/extensions/amp-ad-network-adsense-impl/0.1/amp-ad-network-adsense-impl.js b/extensions/amp-ad-network-adsense-impl/0.1/amp-ad-network-adsense-impl.js
@@ -252,6 +252,7 @@ export class AmpAdNetworkAdsenseImpl extends AmpA4A {
       'bc': global.SVGElement && global.document.createElementNS ? '1' : null,
       'ctypes': this.getCtypes_(),
       'host': this.element.getAttribute('data-ad-host'),
+      'hl': this.element.getAttribute('data-language'),
       'to': this.element.getAttribute('data-tag-origin'),
       'pv': sharedStateParams.pv,
       'channel': this.element.getAttribute('data-ad-channel'),

diff --git a/extensions/amp-ad-network-adsense-impl/0.1/test/test-amp-ad-network-adsense-impl.js b/extensions/amp-ad-network-adsense-impl/0.1/test/test-amp-ad-network-adsense-impl.js
@@ -477,6 +477,7 @@ describes.realWin('amp-ad-network-adsense-impl', {
     });
     it('returns the right URL', () => {
       element.setAttribute('data-ad-slot', 'some_slot');
+      element.setAttribute('data-language', 'lxz');
       return impl.getAdUrl().then(url => {
         [
           /^https:\/\/googleads\.g\.doubleclick\.net\/pagead\/ads/,
@@ -509,6 +510,7 @@ describes.realWin('amp-ad-network-adsense-impl', {
           /(\?|&)isw=\d+(&|$)/,
           /(\?|&)ish=\d+(&|$)/,
           /(\?|&)pfx=(1|0)(&|$)/,
+          /(\?|&)hl=lxz(&|$)/,
           /(\?|&)url=https?%3A%2F%2F[a-zA-Z0-9.:%]+(&|$)/,
           /(\?|&)top=localhost(&|$)/,
           /(\?|&)ref=https%3A%2F%2Facme.org%2F(&|$)/,