Fixes 2 unit tests (#14561)

ampproject · Apr 12, 2018 · 839ec0e · 839ec0e
1 parent 14a9c4b
commit 839ec0e
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 2 deletions.
diff --git a/extensions/amp-analytics/0.1/test/test-amp-analytics.js b/extensions/amp-analytics/0.1/test/test-amp-analytics.js
@@ -267,10 +267,26 @@ describes.realWin('amp-analytics', {
 
   it('does not unnecessarily preload iframe transport script', function() {
     const el = doc.createElement('amp-analytics');
+    el.setAttribute('type', 'foo');
     doc.body.appendChild(el);
     const analytics = new AmpAnalytics(el);
     sandbox.stub(analytics, 'assertAmpAdResourceId').callsFake(() => 'fakeId');
     const preloadSpy = sandbox.spy(analytics, 'preload');
+    sandbox.stub(analytics, 'predefinedConfig_').value(
+        {
+          'foo': {
+            'triggers': {
+              'sample_visibility_trigger': {
+                'on': 'visible',
+                'request': 'sample_visibility_request',
+              },
+            },
+            'requests': {
+              'sample_visibility_request': 'fake-request',
+            },
+          },
+        }
+    );
     analytics.buildCallback();
     analytics.preconnectCallback();
     return analytics.layoutCallback().then(() => {

diff --git a/extensions/amp-analytics/0.1/test/test-visibility-manager.js b/extensions/amp-analytics/0.1/test/test-visibility-manager.js
@@ -283,11 +283,19 @@ describes.fakeWin('VisibilityManagerForDoc', {amp: true}, env => {
 
   it('does not allow min==max, when they are neither 0 nor 100', () => {
     let spec = {visiblePercentageThresholds: [[50, 50]]};
-    root.listenRoot(spec, null, null, null);
+    allowConsoleError(() => {
+      // Expect user().error(TAG,
+      //   'visiblePercentageThresholds entry invalid min/max value')
+      root.listenRoot(spec, null, null, null);
+    });
     expect(root.models_).to.have.length(0);
     root.dispose();
     spec = {visiblePercentageThresholds: [[0, 10], [10, 10], [30, 30]]};
-    root.listenRoot(spec, null, null, null);
+    allowConsoleError(() => {
+      // On the [10, 10] only, again expect user().error(TAG,
+      //   'visiblePercentageThresholds entry invalid min/max value')
+      root.listenRoot(spec, null, null, null);
+    });
     expect(root.models_).to.have.length(1);
     root.dispose();
   });