✅ Fixes 2 unit tests #14561
Merged
✅ Fixes 2 unit tests #14561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonkeller
commented
Apr 11, 2018
| sandbox.stub(analytics, 'predefinedConfig_').value( | ||
| { | ||
| 'foo': { | ||
| 'triggers': { |
There was a problem hiding this comment.
Lack of this was causing error at https://github.com/ampproject/amphtml/blob/master/extensions/amp-analytics/0.1/amp-analytics.js#L248
jonkeller
commented
Apr 11, 2018
| root.listenRoot(spec, null, null, null); | ||
| allowConsoleError(() => { | ||
| // Expect user().error(TAG, | ||
| // 'visiblePercentageThresholds entry invalid min/max value') |
There was a problem hiding this comment.
jonkeller
commented
Apr 11, 2018
| root.listenRoot(spec, null, null, null); | ||
| allowConsoleError(() => { | ||
| // On the [10, 10] only, again expect user().error(TAG, | ||
| // 'visiblePercentageThresholds entry invalid min/max value') |
There was a problem hiding this comment.
Comment should say "[10, 10] and [30, 30] only". I noticed this after it was merged, so corrected in #14576
bradfrizzell
approved these changes
Apr 11, 2018
keithwrightbos
approved these changes
Apr 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the 2 unit tests assigned to me in #14336
In the first test, we were getting a console error which was not necessary, so fixed the code to not cause that.
In the second test, we were testing an error condition which was expected to generate a console error, so wrapped that in allowConsoleError()