Skip to content

Commit

Permalink
Pin yarn stable version to 1.22.4 (#30658)
Browse files Browse the repository at this point in the history
  • Loading branch information
rsimha committed Oct 14, 2020
1 parent eadccc2 commit b025f30
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 6 deletions.
3 changes: 0 additions & 3 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,6 @@ notifications:
on_success: change
on_failure: change
before_install:
# Install Yarn v1.22.5 (Xenial's built-in version v1.15.2 is outdated)
- curl -o- -L https://yarnpkg.com/install.sh | bash -s -- --version 1.22.5
- export PATH="$HOME/.yarn/bin:$HOME/.config/yarn/global/node_modules/.bin:$PATH"
# Override Xenial's default Java version (github.com/travis-ci/travis-ci/issues/10290)
- export PATH=$(echo "$PATH" | sed -e 's/:\/usr\/local\/lib\/jvm\/openjdk11\/bin//')
- export JAVA_HOME=/usr/lib/jvm/java-1.8.0-openjdk-amd64
Expand Down
7 changes: 4 additions & 3 deletions build-system/common/check-package-manager.js
Original file line number Diff line number Diff line change
Expand Up @@ -183,9 +183,10 @@ function getNodeLatestLtsVersion(distributionsJson) {
// If yarn is being run, perform a version check and proceed with the install.
function checkYarnVersion() {
const yarnVersion = getStdout(yarnExecutable + ' --version').trim();
// TODO (KB): Revert #30478 once `yarn` stable is fixed
// At this time current stable is failing GPG checks.
const stableVersion = '1.22.5';
// TODO (kristoferbaxter): Remove once yarn stable is fixed.
// TODO (rsimha): Revisit the use of yarn v1 for AMP package management.
// At this time current stable version is failing GPG checks, so we use 1.22.4.
const stableVersion = '1.22.4';
if (stableVersion === '') {
console.log(
yellow(
Expand Down

0 comments on commit b025f30

Please sign in to comment.