🏗 Pin yarn stable version to v1.22.4
#30658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwinmombay
approved these changes
Oct 14, 2020
| // TODO (KB): Revert #30478 once `yarn` stable is fixed | ||
| // At this time current stable is failing GPG checks. | ||
| const stableVersion = '1.22.5'; | ||
| // TODO (kristoferbaxter): Remove once yarn stable is fixed. |
There was a problem hiding this comment.
Thank you for fixing up my incorrectly formatted todo as well!
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AMP uses
yarnv1 for package management. The latest two stable versions 1.22.10 and 1.22.5 appear to have intermittent GPG signature problems during installation. This PR does two things:yarnto 1.22.4The long term fix is to pursue a replacement of our package management solution via #30518.