create 1.0 version for amp-sticky-ad extension (#5923)

* add 1.0 folder * add test * test fixed by Dima * fix tests * fix share-tracking test
ampproject · Nov 2, 2016 · d5bcdc4 · d5bcdc4
1 parent 915c99c
commit d5bcdc4
Show file tree

Hide file tree

Showing 11 changed files with 998 additions and 266 deletions.
diff --git a/examples/sticky.ads.amp.html b/examples/sticky.ads.amp.html
@@ -146,7 +146,7 @@
 
   </style>
   <script async custom-element="amp-lightbox" src="https://cdn.ampproject.org/v0/amp-lightbox-0.1.js"></script>
-  <script async custom-element="amp-sticky-ad" src="https://cdn.ampproject.org/v0/amp-sticky-ad-0.1.js"></script>
+  <script async custom-element="amp-sticky-ad" src="https://cdn.ampproject.org/v0/amp-sticky-ad-1.0.js"></script>
   <style amp-boilerplate>body{-webkit-animation:-amp-start 8s steps(1,end) 0s 1 normal both;-moz-animation:-amp-start 8s steps(1,end) 0s 1 normal both;-ms-animation:-amp-start 8s steps(1,end) 0s 1 normal both;animation:-amp-start 8s steps(1,end) 0s 1 normal both}@-webkit-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-moz-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-ms-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@-o-keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}@keyframes -amp-start{from{visibility:hidden}to{visibility:visible}}</style><noscript><style amp-boilerplate>body{-webkit-animation:none;-moz-animation:none;-ms-animation:none;animation:none}</style></noscript>
   <script async src="https://cdn.ampproject.org/v0.js"></script>
   <script async src="./viewer-integr.js" data-amp-report-test="viewer-integr.js"></script>

diff --git a/extensions/amp-share-tracking/0.1/amp-share-tracking.js b/extensions/amp-share-tracking/0.1/amp-share-tracking.js
@@ -210,6 +210,4 @@ export class AmpShareTracking extends AMP.BaseElement {
 
 
 // Install the extension.
-AMP.extension('amp-share-tracking', AMP => {
-  AMP.registerElement('amp-share-tracking', AmpShareTracking);
-});
+AMP.registerElement('amp-share-tracking', AmpShareTracking);
diff --git a/extensions/amp-sticky-ad/0.1/amp-sticky-ad.js b/extensions/amp-sticky-ad/0.1/amp-sticky-ad.js
@@ -238,4 +238,6 @@ class AmpStickyAd extends AMP.BaseElement {
   }
 }
 
-AMP.registerElement('amp-sticky-ad', AmpStickyAd, CSS);
+AMP.extension('amp-sticky-ad', AMP => {
+  AMP.registerElement('amp-sticky-ad', AmpStickyAd, CSS);
+});