create 1.0 version for amp-sticky-ad extension #5923
Conversation
|
I am having test failure withe message
I have already adopted the |
|
Thanks to @dvoytenko, finally fixed the tests. @erwinmombay PTAL |
| * limitations under the License. | ||
| */ | ||
|
|
||
| import {CSS} from '../../../build/amp-sticky-ad-1.0.css'; |
There was a problem hiding this comment.
qq beside version change there isn't actual any change yet to the code right?
There was a problem hiding this comment.
nope. I feel it would be too much for one PR, and hard to diff the changes in this PR. so i simply copied the code.
* add 1.0 folder * add test * test fixed by Dima * fix tests * fix share-tracking test added html_format: AMP @powdercloud new line in test-amp-apester-media validator fix #2 removed decodeUrl validator fix: data-apester-media to data-apester-media-id minor changes to css and loader refactor(css): change css classes css
* add 1.0 folder * add test * test fixed by Dima * fix tests * fix share-tracking test added html_format: AMP @powdercloud new line in test-amp-apester-media validator fix #2 removed decodeUrl validator fix: data-apester-media to data-apester-media-id minor changes to css and loader refactor(css): change css classes css added html_format: AMP @powdercloud new line in test-amp-apester-media validator fix #2 removed decodeUrl validator fix: data-apester-media to data-apester-media-id refactor(css): change css classes css
* add 1.0 folder * add test * test fixed by Dima * fix tests * fix share-tracking test
* add 1.0 folder * add test * test fixed by Dima * fix tests * fix share-tracking test
|
I'm curious, why amp-sticky-ad was bumped to 1.0 while all other extensions are 0.1? The reason is that there are some example pages in AMP repo that still reference 0.1. |
|
We try not to bump up component version because of the painful deprecation process. However we did this to amp-sticky-ad because we decided to change the default UI of the component after UX study, and cannot avoid a breaking change without bumping up version.
Thank you for reporting this. Could you please let me know? This isn't an issue because all 0.1 script point to 1.0 script today. But it's definitely best that we fix them. |
#5921
Validator changes not included.
Actual changes to V1 version not included .