Skip to content

Commit

Permalink
Revert "analytics: bail out for detached targets (#32637)" (#32892)
Browse files Browse the repository at this point in the history
This reverts commit ae4a276.
  • Loading branch information
samouri committed Feb 25, 2021
1 parent ee8ac1e commit db55230
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 24 deletions.
11 changes: 0 additions & 11 deletions extensions/amp-analytics/0.1/instrumentation.js
Expand Up @@ -24,7 +24,6 @@ import {
import {AmpdocAnalyticsRoot, EmbedAnalyticsRoot} from './analytics-root';
import {AnalyticsGroup} from './analytics-group';
import {Services} from '../../../src/services';
import {dev} from '../../../src/log';
import {dict} from '../../../src/utils/object';
import {getFriendlyIframeEmbedOptional} from '../../../src/iframe-helper';
import {
Expand All @@ -35,7 +34,6 @@ import {
} from '../../../src/service';

const PROP = '__AMP_AN_ROOT';
const TAG = 'ANALYTICS-INSTRUMENTATION';

/**
* @implements {../../../src/service.Disposable}
Expand Down Expand Up @@ -104,15 +102,6 @@ export class InstrumentationService {
vars = dict(),
enableDataVars = true
) {
if (!target.isConnected) {
dev().error(
TAG,
'Attempting to trigger event for detached target: %s',
target
);
return;
}

const event = new AnalyticsEvent(target, eventType, vars, enableDataVars);
const root = this.findRoot_(target);
const trackerName = getTrackerKeyName(eventType);
Expand Down
13 changes: 0 additions & 13 deletions extensions/amp-analytics/0.1/test/test-instrumentation.js
Expand Up @@ -63,19 +63,6 @@ describes.realWin('InstrumentationService', {amp: 1}, (env) => {
expect(event.type).to.equal('test-event');
expect(event.vars).to.deep.equal({foo: 'bar'});
});

it('should bail and emit error if element is detached', () => {
expectAsyncConsoleError(/detached/);
const detached = ampdoc.win.document.createElement('div');
const tracker = root.getTracker(
AnalyticsEventType.CUSTOM,
CustomEventTracker
);
const triggerStub = env.sandbox.stub(tracker, 'trigger');
service.triggerEventForTarget(detached, 'test-event');

expect(triggerStub).not.called;
});
});

describes.realWin(
Expand Down

0 comments on commit db55230

Please sign in to comment.