analytics: bail out for detached targets #32637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micajuine-ho
approved these changes
Feb 12, 2021
|
This pull request introduces 3 alerts when merging edef13a into deba5a4 - view on LGTM.com new alerts:
|
This was referenced Feb 14, 2021
samouri
added a commit
that referenced
this pull request
Feb 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
summary
Followup to #32578.
When a node is detached, we can't perform our standard analytics flow for it (which includes finding its window + ampdoc).
While I'm sure each individual instance where this could occur needs its own handling, we can at least throw a more specific error so that we can identify the issue correctly (as well as not spiral into other unrelated errors due to unexpected throws - like missing AMP_TOP etc.).
Example error:
