📦 Update linting devDependencies (#36856)

* 📦 Update linting devDependencies * `amp lint --fix` --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Daniel Rozenberg <rodaniel@google.com>
ampproject · May 23, 2023 · fc84bdb · fc84bdb
1 parent 87aae46
commit fc84bdb
Show file tree

Hide file tree

Showing 36 changed files with 1,529 additions and 928 deletions.
diff --git a/build-system/common/esbuild-babel.js b/build-system/common/esbuild-babel.js
@@ -38,7 +38,7 @@ let transformCache;
 function getEsbuildBabelPlugin(
   callerName,
   enableCache,
-  {preSetup = () => {}, postLoad = () => {}, plugins} = {}
+  {plugins, postLoad = () => {}, preSetup = () => {}} = {}
 ) {
   const babelMaps = new Map();
 

diff --git a/build-system/server/app-index/template.js b/build-system/server/app-index/template.js
@@ -68,8 +68,8 @@ function renderTemplate(opt_params = {}) {
     basepath = '/',
     css,
     fileSet = [],
-    serveMode = 'default',
     htmlEnvelopePrefix = '/',
+    serveMode = 'default',
   } = opt_params;
 
   const body = joinFragments([

diff --git a/build-system/tasks/e2e/describes-e2e.js b/build-system/tasks/e2e/describes-e2e.js
@@ -670,7 +670,7 @@ function getDriver({headless = false}, browserName, deviceName) {
  */
 async function setUpTest(
   {ampDriver, controller, environment},
-  {testUrl = '', version, experiments = [], initialRect}
+  {experiments = [], initialRect, testUrl = '', version}
 ) {
   const url = new URL(testUrl);
 

diff --git a/extensions/amp-date-countdown/1.0/component.js b/extensions/amp-date-countdown/1.0/component.js
@@ -58,12 +58,12 @@ const DEFAULT_RENDER = (data) =>
  * @return {PreactDef.Renderable}
  */
 export function BentoDateCountdown({
-  datetime,
-  whenEnded = DEFAULT_WHEN_ENDED,
-  locale = DEFAULT_LOCALE,
   biggestUnit = DEFAULT_BIGGEST_UNIT,
   countUp = DEFAULT_COUNT_UP,
+  datetime,
+  locale = DEFAULT_LOCALE,
   render = DEFAULT_RENDER,
+  whenEnded = DEFAULT_WHEN_ENDED,
   ...rest
 }) {
   useResourcesNotify();

diff --git a/extensions/amp-date-picker/1.0/component/component.tsx b/extensions/amp-date-picker/1.0/component/component.tsx
@@ -24,7 +24,7 @@ function BentoDatePickerWithRef(
   props: BentoDatePickerProps,
   ref: Ref<SingleDatePickerAPI | DateRangePickerAPI>
 ) {
-  const {children, type = 'single', onError = DEFAULT_ON_ERROR} = props;
+  const {children, onError = DEFAULT_ON_ERROR, type = 'single'} = props;
 
   const DatePicker = datePickerForType[type];
 

diff --git a/extensions/amp-date-picker/1.0/component/single-date-picker.tsx b/extensions/amp-date-picker/1.0/component/single-date-picker.tsx
@@ -31,12 +31,12 @@ function SingleDatePickerWithRef(
   const {
     blockedDates,
     formatDate,
-    parseDate,
     initialVisibleMonth,
     inputSelector = DEFAULT_INPUT_SELECTOR,
     mode,
     openAfterClear,
     openAfterSelect,
+    parseDate,
     today,
   } = useDatePickerContext();
 

diff --git a/extensions/amp-date-picker/1.0/component/use-date-picker-context.tsx b/extensions/amp-date-picker/1.0/component/use-date-picker-context.tsx
@@ -54,25 +54,25 @@ const DATE_FORMAT = 'cccc, LLLL d, yyyy';
 export function DatePickerProvider({
   allowBlockedEndDate,
   allowBlockedRanges,
+  blocked,
   children,
   endInputSelector = DEFAULT_END_INPUT_SELECTOR,
   format = ISO_8601,
+  highlighted,
   inputSelector = DEFAULT_INPUT_SELECTOR,
   locale = DEFAULT_LOCALE,
   max,
+  maximumNights = 0,
+  min: optionalMin,
+  minimumNights = 1,
   mode = 'static',
   monthFormat = DEFAULT_MONTH_FORMAT,
+  numberOfMonths = 1,
   onError = DEFAULT_ON_ERROR,
   startInputSelector = DEFAULT_START_INPUT_SELECTOR,
   today = getCurrentDate(),
   type = 'single',
   weekDayFormat = DEFAULT_WEEK_DAY_FORMAT,
-  maximumNights = 0,
-  minimumNights = 1,
-  numberOfMonths = 1,
-  min: optionalMin,
-  blocked,
-  highlighted,
   ...rest
 }: BentoDatePickerProps) {
   const min = optionalMin || today;

diff --git a/extensions/amp-experiment/1.0/apply-experiment.js b/extensions/amp-experiment/1.0/apply-experiment.js
@@ -1,13 +1,13 @@
 import {user, userAssert} from '#utils/log';
 
-import {
-  assertMutationRecordFormat,
-  getElementsFromMutationRecordSelector,
-} from './mutation-record';
 import {AttributeMutationDefaultClass} from './mutation/attribute-mutation-default-class';
 import {AttributeMutationDefaultStyle} from './mutation/attribute-mutation-default-style';
 import {AttributeMutationDefaultUrl} from './mutation/attribute-mutation-default-url';
 import {CharacterDataMutation} from './mutation/character-data-mutation';
+import {
+  assertMutationRecordFormat,
+  getElementsFromMutationRecordSelector,
+} from './mutation-record';
 
 const TAG = 'amp-experiment apply-experiment';
 

diff --git a/extensions/amp-gist/1.0/component.js b/extensions/amp-gist/1.0/component.js
@@ -13,11 +13,11 @@ const FULL_HEIGHT = '100%';
  * @return {PreactDef.Renderable}
  */
 export function BentoGist({
-  gistId,
   file,
-  title = DEFAULT_TITLE,
+  gistId,
   requestResize,
   style,
+  title = DEFAULT_TITLE,
   ...rest
 }) {
   const iframeRef = useRef(null);

diff --git a/extensions/amp-list/1.0/component.js b/extensions/amp-list/1.0/component.js
@@ -100,18 +100,18 @@ function getItemsFromPage(pageData, itemsKey) {
  */
 export function BentoListWithRef(
   {
-    src = null,
+    errorTemplate = defaultErrorTemplate,
     fetchJson = xhrUtils.fetchJson,
     itemsKey = 'items',
-    maxItems = 0,
     loadMore: loadMoreMode = 'none',
     loadMoreBookmark = 'load-more-src',
-    viewportBuffer = 2.0, // When loadMore === 'auto', keep loading up to 2 viewports of data
+    loadMoreTemplate = defaultLoadMoreTemplate,
+    loadingTemplate = defaultLoadingTemplate, // When loadMore === 'auto', keep loading up to 2 viewports of data
+    maxItems = 0,
+    src = null,
     template: itemTemplate = defaultItemTemplate,
+    viewportBuffer = 2.0,
     wrapperTemplate = defaultWrapperTemplate,
-    loadMoreTemplate = defaultLoadMoreTemplate,
-    loadingTemplate = defaultLoadingTemplate,
-    errorTemplate = defaultErrorTemplate,
     ...rest
   },
   ref

diff --git a/extensions/amp-render/1.0/component.js b/extensions/amp-render/1.0/component.js
@@ -26,14 +26,14 @@ const DEFAULT_GET_JSON = (url) => {
  */
 export function RenderWithRef(
   {
-    src = '',
-    getJson = DEFAULT_GET_JSON,
-    render = DEFAULT_RENDER,
     ariaLiveValue = 'polite',
-    onLoading,
+    getJson = DEFAULT_GET_JSON,
+    onError,
     onLoad,
+    onLoading,
     onRefresh,
-    onError,
+    render = DEFAULT_RENDER,
+    src = '',
     ...rest
   },
   ref

diff --git a/extensions/amp-selector/1.0/component.js b/extensions/amp-selector/1.0/component.js
@@ -43,16 +43,16 @@ export const KEYBOARD_SELECT_MODE = {
 function SelectorWithRef(
   {
     as: Comp = 'div',
-    disabled,
+    children,
     defaultValue = [],
+    disabled,
     form,
     keyboardSelectMode = KEYBOARD_SELECT_MODE.NONE,
-    value,
     multiple,
     name,
     onChange,
     role = 'listbox',
-    children,
+    value,
     ...rest
   },
   ref

diff --git a/extensions/amp-stream-gallery/0.1/test/test-amp-stream-gallery.js b/extensions/amp-stream-gallery/0.1/test/test-amp-stream-gallery.js
@@ -112,10 +112,10 @@ describes.realWin(
     }
 
     async function getGallery({
-      slideCount = 5,
+      attrs = {},
       customArrows = false,
+      slideCount = 5,
       width,
-      attrs = {},
     } = {}) {
       const el = doc.createElement('amp-stream-gallery');
       el.setAttribute('layout', 'fixed');

diff --git a/extensions/amp-stream-gallery/1.0/component.js b/extensions/amp-stream-gallery/1.0/component.js
@@ -28,18 +28,18 @@ const OUTSET_ARROWS_WIDTH = 100;
  */
 function BentoStreamGalleryWithRef(props, ref) {
   const {
-    arrowPrevAs = DefaultArrow,
     arrowNextAs = DefaultArrow,
+    arrowPrevAs = DefaultArrow,
     children,
-    [propName('class')]: className,
     extraSpace,
     maxItemWidth = Number.MAX_VALUE,
-    minItemWidth = 1,
     maxVisibleCount = Number.MAX_VALUE,
+    minItemWidth = 1,
     minVisibleCount = 1,
     outsetArrows,
     peek = 0,
     slideAlign = 'start',
+    [propName('class')]: className,
     ...rest
   } = props;
   const classes = useStyles();

diff --git a/extensions/amp-truncate-text/0.1/test/test-amp-truncate-text.js b/extensions/amp-truncate-text/0.1/test/test-amp-truncate-text.js
@@ -48,7 +48,7 @@ describes.realWin(
 
       async function createElement(
         content,
-        {width, height, layout = 'fixed', container = doc.body}
+        {container = doc.body, height, layout = 'fixed', width}
       ) {
         const element = win.document.createElement('amp-truncate-text');
         element.setAttribute('layout', layout);

diff --git a/extensions/amp-video-iframe/1.0/amp-video-iframe.js b/extensions/amp-video-iframe/1.0/amp-video-iframe.js
@@ -1,6 +1,6 @@
 import {BUBBLE_MESSAGE_EVENTS} from '#bento/apis/video-iframe-api';
-import {BaseElement} from '#bento/components/bento-video-iframe/1.0/base-element';
 import {AmpVideoBaseElement} from '#bento/components/bento-video/1.0/video-base-element';
+import {BaseElement} from '#bento/components/bento-video-iframe/1.0/base-element';
 
 import {measureIntersection} from '#core/dom/layout/intersection';
 

diff --git a/extensions/amp-video/1.0/storybook/_helpers.js b/extensions/amp-video/1.0/storybook/_helpers.js
@@ -1,9 +1,9 @@
 import * as Preact from '#preact';
 
 export const VideoElementWithActions = ({
-  id,
-  children,
   actions = ['play', 'pause', 'mute', 'unmute', 'fullscreen'],
+  children,
+  id,
 }) => (
   <div style="max-width: 800px">
     <p style={{display: 'flex'}}>