Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

amp-youtube: "No cookie" option #11956

Closed
saitho opened this issue Nov 7, 2017 · 4 comments
Closed

amp-youtube: "No cookie" option #11956

saitho opened this issue Nov 7, 2017 · 4 comments
Assignees
Milestone

Comments

@saitho
Copy link
Contributor

saitho commented Nov 7, 2017

What's the issue?

In some cases it might be necessary to embed a YouTube video without cookies (legal reasons et cetera). There is a way to embed the YouTube player without cookies with a special embed URL – you just have to add "-nocookie" between youtube and .com.
E.g. https://www.youtube-nocookie.com/embed/jpyHTTtddUo?enablejsapi=1

Implementation proposal

What browsers are affected?

None, as this is a new feature.

Which AMP version is affected?

None, as this is a new feature.

@aghassemi
Copy link
Contributor

@saitho Thanks, good feature to add. Would you be interested in contributing this feature by sending a PR? AMP is fairly streamlined for quick external contributions. If you are interested, checkout https://github.com/ampproject/amphtml/blob/master/CONTRIBUTING.md to get started.

@aghassemi aghassemi added this to the New FRs milestone Nov 7, 2017
@saitho
Copy link
Contributor Author

saitho commented Nov 7, 2017

I already thought about that. :) I'll be discussing that with my company.

@aghassemi
Copy link
Contributor

@sahirsait for the attribute, let's use credentials with values of omit and include instead of nocookie.(with default of include). This will align better with amp-list which already has such a mode.

@saitho
Copy link
Contributor Author

saitho commented Nov 9, 2017

That makes sense. I changed the attribute name in the issue text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants