Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Master feature] Leaner AMP #14392

Closed
choumx opened this Issue Apr 3, 2018 · 6 comments

Comments

@choumx
Copy link
Collaborator

choumx commented Apr 3, 2018

Goal: Reduce size of AMP’s main JS binary by 50%.
Corollary: Do not regress parse, compile, and execution time of the JS.

@choumx choumx added this to Feature Backlog in AMP HTML Project Roadmap via automation Apr 3, 2018

@choumx

This comment has been minimized.

Copy link
Collaborator Author

choumx commented Apr 3, 2018

Work for Q2 2018:

  • Automated binary size tracking & dashboard
  • Deliver module/no-module versions of AMP main JS binary
  • Bundle analysis and strategy planning
  • Reduce binary size by 10%

@choumx choumx moved this from Feature Backlog to In Progress in AMP HTML Project Roadmap Apr 3, 2018

@choumx

This comment has been minimized.

Copy link
Collaborator Author

choumx commented Apr 6, 2018

@choumx

This comment has been minimized.

Copy link
Collaborator Author

choumx commented May 10, 2018

Note: Individual tasks tracked in Build Size project.

@choumx

This comment has been minimized.

Copy link
Collaborator Author

choumx commented May 15, 2018

Accidental close.

@choumx choumx reopened this May 15, 2018

AMP HTML Project Roadmap automation moved this from Done to In Progress May 15, 2018

Build Size automation moved this from Done to In progress May 15, 2018

@rsimha

This comment has been minimized.

Copy link
Collaborator

rsimha commented May 15, 2018

Sheesh, Required in order to fix closed this :/

@ampprojectbot ampprojectbot added this to the Pending Triage milestone Jun 5, 2018

AMP HTML Project Roadmap automation moved this from In Development to Shipped Jul 16, 2018

Build Size automation moved this from In progress to Done Jul 16, 2018

@kristoferbaxter

This comment has been minimized.

Copy link
Collaborator

kristoferbaxter commented Jul 16, 2018

Closed in favor of #16745.

jridgewell added a commit to jridgewell/amphtml that referenced this issue Aug 30, 2018

Bump
```
[16:36:45] Finished 'dist' after 2.5 min
[16:36:49] Using gulpfile ~/src/amphtml/gulpfile.js
[16:36:49] Starting 'bundle-size'...
[16:36:49] Running npx bundlesize -f "./dist/v0.js" -s "81.15KB"...
[16:36:49] FAIL  ./dist/v0.js: 81.18KB > maxSize 81.15KB (gzip)
[16:36:49] ERROR: bundlesize found that ./dist/v0.js has exceeded its size cap of 81.15KB.
[16:36:49] This is part of a new effort to reduce AMP's binary size (ampproject#14392).
[16:36:49] Please contact @choumx or @jridgewell for assistance.
[16:36:49] Finished 'bundle-size' after 498 ms
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.