Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Master feature] Leaner AMP #14392

Closed
dreamofabear opened this issue Apr 3, 2018 · 6 comments · Fixed by #15256
Closed

[Master feature] Leaner AMP #14392

dreamofabear opened this issue Apr 3, 2018 · 6 comments · Fixed by #15256
Assignees
@kristoferbaxter @dreamofabear
Projects
AMP HTML Project Roadmap Build Size
Milestone
Pending Triage

Comments

@dreamofabear
Copy link

dreamofabear commented Apr 3, 2018 •
edited
Loading

Goal: Reduce size of AMP’s main JS binary by 50%.
Corollary: Do not regress parse, compile, and execution time of the JS.
@dreamofabear dreamofabear added this to Feature Backlog in AMP HTML Project Roadmap via automation Apr 3, 2018
@dreamofabear
Copy link
Author

Work for Q2 2018:

  • Automated binary size tracking & dashboard
  • Deliver module/no-module versions of AMP main JS binary
  • Bundle analysis and strategy planning
  • Reduce binary size by 10%

@dreamofabear dreamofabear mentioned this issue Apr 3, 2018
Closed
@dreamofabear dreamofabear moved this from Feature Backlog to In Progress in AMP HTML Project Roadmap Apr 3, 2018
@dreamofabear
Copy link
Author

Bundle analyses from April 3, 2018:

@cvializ cvializ mentioned this issue Apr 9, 2018
Merged
This was referenced May 4, 2018
Merged
Merged
@dreamofabear dreamofabear added this to To do in Build Size via automation May 10, 2018
@dreamofabear
Copy link
Author

Note: Individual tasks tracked in Build Size project.

This was referenced May 14, 2018
Merged
Closed
AMP HTML Project Roadmap automation moved this from In Progress to Done May 14, 2018
Build Size automation moved this from To do to Done May 14, 2018
@dreamofabear
Copy link
Author

Accidental close.

@dreamofabear dreamofabear reopened this May 15, 2018
AMP HTML Project Roadmap automation moved this from Done to In Progress May 15, 2018
Build Size automation moved this from Done to In progress May 15, 2018
@rsimha
Copy link
Contributor

rsimha commented May 15, 2018

Sheesh, Required in order to fix closed this :/

@ampprojectbot ampprojectbot added this to the Pending Triage milestone Jun 5, 2018
AMP HTML Project Roadmap automation moved this from In Development to Shipped Jul 16, 2018
Build Size automation moved this from In progress to Done Jul 16, 2018
@kristoferbaxter
Copy link
Contributor

Closed in favor of #16745.

@pm-harshad-mane pm-harshad-mane mentioned this issue Jul 24, 2018
Merged
jridgewell added a commit to jridgewell/amphtml that referenced this issue Aug 30, 2018
@jridgewell
Bump
56416ce 
```
[16:36:45] Finished 'dist' after 2.5 min
[16:36:49] Using gulpfile ~/src/amphtml/gulpfile.js
[16:36:49] Starting 'bundle-size'...
[16:36:49] Running npx bundlesize -f "./dist/v0.js" -s "81.15KB"...
[16:36:49] FAIL  ./dist/v0.js: 81.18KB > maxSize 81.15KB (gzip)
[16:36:49] ERROR: bundlesize found that ./dist/v0.js has exceeded its size cap of 81.15KB.
[16:36:49] This is part of a new effort to reduce AMP's binary size (ampproject#14392).
[16:36:49] Please contact @choumx or @jridgewell for assistance.
[16:36:49] Finished 'bundle-size' after 498 ms
```
@Masterci84 Masterci84 mentioned this issue Oct 1, 2023
Open
@Elisabeth1983 Elisabeth1983 mentioned this issue Oct 2, 2023
Open
@terrorizer1980 terrorizer1980 mentioned this issue Oct 2, 2023
Open
@muratkalenderoglu muratkalenderoglu mentioned this issue Oct 2, 2023
Open
@Elisabeth1983 Elisabeth1983 mentioned this issue Oct 14, 2023
Open
@terrorizer1980 terrorizer1980 mentioned this issue Nov 29, 2023
Open
@Masterci84 Masterci84 mentioned this issue Nov 30, 2023
Open
@terrorizer1980 terrorizer1980 mentioned this issue Dec 1, 2023
Open
@Elisabeth1983 Elisabeth1983 mentioned this issue Dec 19, 2023
Open
@muratkalenderoglu muratkalenderoglu mentioned this issue Dec 19, 2023
Open
@Elisabeth1983 Elisabeth1983 mentioned this issue Jan 9, 2024
Open
@Masterci84 Masterci84 mentioned this issue Jan 9, 2024
Open
@muratkalenderoglu muratkalenderoglu mentioned this issue Jan 9, 2024
Open
@terrorizer1980 terrorizer1980 mentioned this issue Jan 10, 2024
Open
@Masterci84 Masterci84 mentioned this issue Feb 11, 2024
Open
@muratkalenderoglu muratkalenderoglu mentioned this issue Feb 11, 2024
Open
@terrorizer1980 terrorizer1980 mentioned this issue Feb 11, 2024
Open
@Elisabeth1983 Elisabeth1983 mentioned this issue Feb 11, 2024
Open
@muratkalenderoglu muratkalenderoglu mentioned this issue Mar 22, 2024
Open
@Elisabeth1983 Elisabeth1983 mentioned this issue Mar 22, 2024
Open
@Masterci84 Masterci84 mentioned this issue Mar 22, 2024
Open
@terrorizer1980 terrorizer1980 mentioned this issue Mar 23, 2024
Open
@muratkalenderoglu muratkalenderoglu mentioned this issue May 13, 2024
Open
@Elisabeth1983 Elisabeth1983 mentioned this issue May 13, 2024
Open
@Masterci84 Masterci84 mentioned this issue May 14, 2024
Open
@Elisabeth1983 Elisabeth1983 mentioned this issue May 14, 2024
Open
@terrorizer1980 terrorizer1980 mentioned this issue May 14, 2024
Open
@muratkalenderoglu muratkalenderoglu mentioned this issue May 20, 2024
Open
@Elisabeth1983 Elisabeth1983 mentioned this issue May 20, 2024
Open
@Masterci84 Masterci84 mentioned this issue May 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kristoferbaxter kristoferbaxter

@dreamofabear dreamofabear

Labels
None yet
Projects
AMP HTML Project Roadmap
  
Shipped
Build Size
  
Done
Milestone
Pending Triage
Development

Successfully merging a pull request may close this issue.

🏗 During PR checks, lint only the files in the PR, and flag errors instead of warnings
4 participants
@kristoferbaxter @dreamofabear @ampprojectbot @rsimha