Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix and unskip amp-brid-player tests #14833

Closed
cvializ opened this issue Apr 24, 2018 · 1 comment
Closed

fix and unskip amp-brid-player tests #14833

cvializ opened this issue Apr 24, 2018 · 1 comment
Assignees
@cvializ
Labels
P2: Soon Related to: Flaky Tests Type: Bug
Milestone
Backlog Bugs

Comments

@cvializ
Copy link
Contributor

cvializ commented Apr 24, 2018

amp-brid-player is broken due to a bug in their embed html.
screen shot 2018-04-24 at 09 00 11
@cvializ cvializ added this to the Backlog Bugs milestone Apr 24, 2018
@cvializ cvializ self-assigned this Apr 24, 2018
@cvializ cvializ mentioned this issue Apr 24, 2018
Merged
@erwinmombay
Copy link
Member

This issue hasn't been updated in awhile. @cvializ Do you have any updates?

cvializ added a commit to cvializ/amphtml that referenced this issue Aug 21, 2018
@cvializ
Unskip amp-brid-player tests ampproject#14833
64338b9
@cvializ cvializ mentioned this issue Aug 21, 2018
Merged
cvializ added a commit that referenced this issue Sep 24, 2018
@cvializ
Unskip amp-brid-player tests #14833 (#17628)
3859679
aghassemi added a commit that referenced this issue Sep 24, 2018
@aghassemi
Revert "Unskip amp-brid-player tests #14833 (#17628)"
2761c97 
This reverts commit 3859679.
jridgewell pushed a commit that referenced this issue Sep 25, 2018
@aghassemi @jridgewell
Revert "⏪Unskip amp-brid-player tests" (#18333)
c88447a 
* Revert "Fix spelling corrections for test-amp-ad-network-adsense-impl.js (Codelab 23) (#18323)"

This reverts commit 86b4990.

* Revert "Remove experiment (#18303)"

This reverts commit 037acf4.

* Revert "Fix spelling corrections for amp-subscriptions.md (Codelab 12) (#18320)"

This reverts commit bef98ea.

* Revert "Prefer American spelling: behaviour -> behavior (#18314)"

This reverts commit 01c27b3.

* Revert "Amp-Instagram: Update amp-instagram.md spelling from 'attept' to 'attempt'. (#18313)"

This reverts commit 7176925.

* Revert "fix spelling of "white listed" from "whitelisted" in readme, for consistency (#18304)"

This reverts commit 9b58f86.

* Revert "Change "whitelisted" to "white listed" (#18301)"

This reverts commit 425cf9f.

* Revert "Fix spelling issue in product page source (#18302)"

This reverts commit 61c7a2a.

* Revert "✨Implement Scroll App connect flow for Safari (#17987)"

This reverts commit 2b04e46.

* Revert "Changed i18n to internationalization (#18307)"

This reverts commit 34e6e54.

* Revert "fix spelling favour into favor (#18299)"

This reverts commit 067f0a6.

* Revert "Add fetch for upstream (#18289)"

This reverts commit e8ada57.

* Revert "Fix typo. (#18274)"

This reverts commit 4272e32.

* Revert "Improve testing section in "getting-started-e2e.md" (#17720)"

This reverts commit 146cde4.

* Revert "Unskip amp-brid-player tests #14833 (#17628)"

This reverts commit 3859679.
GoTcWang pushed a commit to GoTcWang/amphtml that referenced this issue Sep 25, 2018
@cvializ @GoTcWang
Unskip amp-brid-player tests ampproject#14833 (ampproject#17628)
ed9ba32
GoTcWang pushed a commit to GoTcWang/amphtml that referenced this issue Sep 25, 2018
@aghassemi @GoTcWang
Revert "⏪Unskip amp-brid-player tests" (ampproject#18333)
808c8f4 
* Revert "Fix spelling corrections for test-amp-ad-network-adsense-impl.js (Codelab 23) (ampproject#18323)"

This reverts commit 86b4990.

* Revert "Remove experiment (ampproject#18303)"

This reverts commit 037acf4.

* Revert "Fix spelling corrections for amp-subscriptions.md (Codelab 12) (ampproject#18320)"

This reverts commit bef98ea.

* Revert "Prefer American spelling: behaviour -> behavior (ampproject#18314)"

This reverts commit 01c27b3.

* Revert "Amp-Instagram: Update amp-instagram.md spelling from 'attept' to 'attempt'. (ampproject#18313)"

This reverts commit 7176925.

* Revert "fix spelling of "white listed" from "whitelisted" in readme, for consistency (ampproject#18304)"

This reverts commit 9b58f86.

* Revert "Change "whitelisted" to "white listed" (ampproject#18301)"

This reverts commit 425cf9f.

* Revert "Fix spelling issue in product page source (ampproject#18302)"

This reverts commit 61c7a2a.

* Revert "✨Implement Scroll App connect flow for Safari (ampproject#17987)"

This reverts commit 2b04e46.

* Revert "Changed i18n to internationalization (ampproject#18307)"

This reverts commit 34e6e54.

* Revert "fix spelling favour into favor (ampproject#18299)"

This reverts commit 067f0a6.

* Revert "Add fetch for upstream (ampproject#18289)"

This reverts commit e8ada57.

* Revert "Fix typo. (ampproject#18274)"

This reverts commit 4272e32.

* Revert "Improve testing section in "getting-started-e2e.md" (ampproject#17720)"

This reverts commit 146cde4.

* Revert "Unskip amp-brid-player tests ampproject#14833 (ampproject#17628)"

This reverts commit 3859679.
torch2424 pushed a commit to torch2424/amphtml that referenced this issue Oct 10, 2018
@cvializ @torch2424
Unskip amp-brid-player tests ampproject#14833 (ampproject#17628)
838d664
torch2424 pushed a commit to torch2424/amphtml that referenced this issue Oct 10, 2018
@aghassemi @torch2424
Revert "⏪Unskip amp-brid-player tests" (ampproject#18333)
4c83d9c 
* Revert "Fix spelling corrections for test-amp-ad-network-adsense-impl.js (Codelab 23) (ampproject#18323)"

This reverts commit 86b4990.

* Revert "Remove experiment (ampproject#18303)"

This reverts commit 037acf4.

* Revert "Fix spelling corrections for amp-subscriptions.md (Codelab 12) (ampproject#18320)"

This reverts commit bef98ea.

* Revert "Prefer American spelling: behaviour -> behavior (ampproject#18314)"

This reverts commit 01c27b3.

* Revert "Amp-Instagram: Update amp-instagram.md spelling from 'attept' to 'attempt'. (ampproject#18313)"

This reverts commit 7176925.

* Revert "fix spelling of "white listed" from "whitelisted" in readme, for consistency (ampproject#18304)"

This reverts commit 9b58f86.

* Revert "Change "whitelisted" to "white listed" (ampproject#18301)"

This reverts commit 425cf9f.

* Revert "Fix spelling issue in product page source (ampproject#18302)"

This reverts commit 61c7a2a.

* Revert "✨Implement Scroll App connect flow for Safari (ampproject#17987)"

This reverts commit 2b04e46.

* Revert "Changed i18n to internationalization (ampproject#18307)"

This reverts commit 34e6e54.

* Revert "fix spelling favour into favor (ampproject#18299)"

This reverts commit 067f0a6.

* Revert "Add fetch for upstream (ampproject#18289)"

This reverts commit e8ada57.

* Revert "Fix typo. (ampproject#18274)"

This reverts commit 4272e32.

* Revert "Improve testing section in "getting-started-e2e.md" (ampproject#17720)"

This reverts commit 146cde4.

* Revert "Unskip amp-brid-player tests ampproject#14833 (ampproject#17628)"

This reverts commit 3859679.
Enriqe pushed a commit to Enriqe/amphtml that referenced this issue Nov 28, 2018
@cvializ @Enriqe
Unskip amp-brid-player tests ampproject#14833 (ampproject#17628)
3463477
Enriqe pushed a commit to Enriqe/amphtml that referenced this issue Nov 28, 2018
@aghassemi @Enriqe
Revert "⏪Unskip amp-brid-player tests" (ampproject#18333)
454acab 
* Revert "Fix spelling corrections for test-amp-ad-network-adsense-impl.js (Codelab 23) (ampproject#18323)"

This reverts commit 86b4990.

* Revert "Remove experiment (ampproject#18303)"

This reverts commit 037acf4.

* Revert "Fix spelling corrections for amp-subscriptions.md (Codelab 12) (ampproject#18320)"

This reverts commit bef98ea.

* Revert "Prefer American spelling: behaviour -> behavior (ampproject#18314)"

This reverts commit 01c27b3.

* Revert "Amp-Instagram: Update amp-instagram.md spelling from 'attept' to 'attempt'. (ampproject#18313)"

This reverts commit 7176925.

* Revert "fix spelling of "white listed" from "whitelisted" in readme, for consistency (ampproject#18304)"

This reverts commit 9b58f86.

* Revert "Change "whitelisted" to "white listed" (ampproject#18301)"

This reverts commit 425cf9f.

* Revert "Fix spelling issue in product page source (ampproject#18302)"

This reverts commit 61c7a2a.

* Revert "✨Implement Scroll App connect flow for Safari (ampproject#17987)"

This reverts commit 2b04e46.

* Revert "Changed i18n to internationalization (ampproject#18307)"

This reverts commit 34e6e54.

* Revert "fix spelling favour into favor (ampproject#18299)"

This reverts commit 067f0a6.

* Revert "Add fetch for upstream (ampproject#18289)"

This reverts commit e8ada57.

* Revert "Fix typo. (ampproject#18274)"

This reverts commit 4272e32.

* Revert "Improve testing section in "getting-started-e2e.md" (ampproject#17720)"

This reverts commit 146cde4.

* Revert "Unskip amp-brid-player tests ampproject#14833 (ampproject#17628)"

This reverts commit 3859679.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cvializ cvializ

Labels
P2: Soon Related to: Flaky Tests Type: Bug
Projects
None yet
Milestone
Backlog Bugs
Development

No branches or pull requests
2 participants
@erwinmombay @cvializ