Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃摉Spelling tweaks for consistency #18314

Merged
merged 1 commit into from Sep 24, 2018
Merged

馃摉Spelling tweaks for consistency #18314

merged 1 commit into from Sep 24, 2018

Conversation

samjacoby
Copy link
Contributor

Prefer American spelling: behaviour -> behavior. Closes #18105. 馃帄

/cc @cathyxz

nainar
nainar approved these changes Sep 24, 2018
View reviewed changes
Copy link
Contributor

@nainar nainar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the change! :) LGTM! I'll merge this in once Travis is done running!

@nainar nainar merged commit 01c27b3 into ampproject:master Sep 24, 2018
@samjacoby samjacoby deleted the spelling-fix-18105 branch September 24, 2018 22:37
aghassemi added a commit that referenced this pull request Sep 24, 2018
@aghassemi
Revert "Prefer American spelling: behaviour -> behavior (#18314)"
ea4d2a7 
This reverts commit 01c27b3.
jridgewell pushed a commit that referenced this pull request Sep 25, 2018
@aghassemi @jridgewell
Revert "鈴猆nskip amp-brid-player tests" (#18333)
c88447a 
* Revert "Fix spelling corrections for test-amp-ad-network-adsense-impl.js (Codelab 23) (#18323)"

This reverts commit 86b4990.

* Revert "Remove experiment (#18303)"

This reverts commit 037acf4.

* Revert "Fix spelling corrections for amp-subscriptions.md (Codelab 12) (#18320)"

This reverts commit bef98ea.

* Revert "Prefer American spelling: behaviour -> behavior (#18314)"

This reverts commit 01c27b3.

* Revert "Amp-Instagram: Update amp-instagram.md spelling from 'attept' to 'attempt'. (#18313)"

This reverts commit 7176925.

* Revert "fix spelling of "white listed" from "whitelisted" in readme, for consistency (#18304)"

This reverts commit 9b58f86.

* Revert "Change "whitelisted" to "white listed" (#18301)"

This reverts commit 425cf9f.

* Revert "Fix spelling issue in product page source (#18302)"

This reverts commit 61c7a2a.

* Revert "鉁↖mplement Scroll App connect flow for Safari (#17987)"

This reverts commit 2b04e46.

* Revert "Changed i18n to internationalization (#18307)"

This reverts commit 34e6e54.

* Revert "fix spelling favour into favor (#18299)"

This reverts commit 067f0a6.

* Revert "Add fetch for upstream (#18289)"

This reverts commit e8ada57.

* Revert "Fix typo. (#18274)"

This reverts commit 4272e32.

* Revert "Improve testing section in "getting-started-e2e.md" (#17720)"

This reverts commit 146cde4.

* Revert "Unskip amp-brid-player tests #14833 (#17628)"

This reverts commit 3859679.
GoTcWang pushed a commit to GoTcWang/amphtml that referenced this pull request Sep 25, 2018
@samjacoby @GoTcWang
Prefer American spelling: behaviour -> behavior (ampproject#18314)
dbd6016
GoTcWang pushed a commit to GoTcWang/amphtml that referenced this pull request Sep 25, 2018
@aghassemi @GoTcWang
Revert "鈴猆nskip amp-brid-player tests" (ampproject#18333)
808c8f4 
* Revert "Fix spelling corrections for test-amp-ad-network-adsense-impl.js (Codelab 23) (ampproject#18323)"

This reverts commit 86b4990.

* Revert "Remove experiment (ampproject#18303)"

This reverts commit 037acf4.

* Revert "Fix spelling corrections for amp-subscriptions.md (Codelab 12) (ampproject#18320)"

This reverts commit bef98ea.

* Revert "Prefer American spelling: behaviour -> behavior (ampproject#18314)"

This reverts commit 01c27b3.

* Revert "Amp-Instagram: Update amp-instagram.md spelling from 'attept' to 'attempt'. (ampproject#18313)"

This reverts commit 7176925.

* Revert "fix spelling of "white listed" from "whitelisted" in readme, for consistency (ampproject#18304)"

This reverts commit 9b58f86.

* Revert "Change "whitelisted" to "white listed" (ampproject#18301)"

This reverts commit 425cf9f.

* Revert "Fix spelling issue in product page source (ampproject#18302)"

This reverts commit 61c7a2a.

* Revert "鉁↖mplement Scroll App connect flow for Safari (ampproject#17987)"

This reverts commit 2b04e46.

* Revert "Changed i18n to internationalization (ampproject#18307)"

This reverts commit 34e6e54.

* Revert "fix spelling favour into favor (ampproject#18299)"

This reverts commit 067f0a6.

* Revert "Add fetch for upstream (ampproject#18289)"

This reverts commit e8ada57.

* Revert "Fix typo. (ampproject#18274)"

This reverts commit 4272e32.

* Revert "Improve testing section in "getting-started-e2e.md" (ampproject#17720)"

This reverts commit 146cde4.

* Revert "Unskip amp-brid-player tests ampproject#14833 (ampproject#17628)"

This reverts commit 3859679.
torch2424 pushed a commit to torch2424/amphtml that referenced this pull request Oct 10, 2018
@samjacoby @torch2424
Prefer American spelling: behaviour -> behavior (ampproject#18314)
633c19e
torch2424 pushed a commit to torch2424/amphtml that referenced this pull request Oct 10, 2018
@aghassemi @torch2424
Revert "鈴猆nskip amp-brid-player tests" (ampproject#18333)
4c83d9c 
* Revert "Fix spelling corrections for test-amp-ad-network-adsense-impl.js (Codelab 23) (ampproject#18323)"

This reverts commit 86b4990.

* Revert "Remove experiment (ampproject#18303)"

This reverts commit 037acf4.

* Revert "Fix spelling corrections for amp-subscriptions.md (Codelab 12) (ampproject#18320)"

This reverts commit bef98ea.

* Revert "Prefer American spelling: behaviour -> behavior (ampproject#18314)"

This reverts commit 01c27b3.

* Revert "Amp-Instagram: Update amp-instagram.md spelling from 'attept' to 'attempt'. (ampproject#18313)"

This reverts commit 7176925.

* Revert "fix spelling of "white listed" from "whitelisted" in readme, for consistency (ampproject#18304)"

This reverts commit 9b58f86.

* Revert "Change "whitelisted" to "white listed" (ampproject#18301)"

This reverts commit 425cf9f.

* Revert "Fix spelling issue in product page source (ampproject#18302)"

This reverts commit 61c7a2a.

* Revert "鉁↖mplement Scroll App connect flow for Safari (ampproject#17987)"

This reverts commit 2b04e46.

* Revert "Changed i18n to internationalization (ampproject#18307)"

This reverts commit 34e6e54.

* Revert "fix spelling favour into favor (ampproject#18299)"

This reverts commit 067f0a6.

* Revert "Add fetch for upstream (ampproject#18289)"

This reverts commit e8ada57.

* Revert "Fix typo. (ampproject#18274)"

This reverts commit 4272e32.

* Revert "Improve testing section in "getting-started-e2e.md" (ampproject#17720)"

This reverts commit 146cde4.

* Revert "Unskip amp-brid-player tests ampproject#14833 (ampproject#17628)"

This reverts commit 3859679.
Enriqe pushed a commit to Enriqe/amphtml that referenced this pull request Nov 28, 2018
@samjacoby @Enriqe
Prefer American spelling: behaviour -> behavior (ampproject#18314)
14b992e
Enriqe pushed a commit to Enriqe/amphtml that referenced this pull request Nov 28, 2018
@aghassemi @Enriqe
Revert "鈴猆nskip amp-brid-player tests" (ampproject#18333)
454acab 
* Revert "Fix spelling corrections for test-amp-ad-network-adsense-impl.js (Codelab 23) (ampproject#18323)"

This reverts commit 86b4990.

* Revert "Remove experiment (ampproject#18303)"

This reverts commit 037acf4.

* Revert "Fix spelling corrections for amp-subscriptions.md (Codelab 12) (ampproject#18320)"

This reverts commit bef98ea.

* Revert "Prefer American spelling: behaviour -> behavior (ampproject#18314)"

This reverts commit 01c27b3.

* Revert "Amp-Instagram: Update amp-instagram.md spelling from 'attept' to 'attempt'. (ampproject#18313)"

This reverts commit 7176925.

* Revert "fix spelling of "white listed" from "whitelisted" in readme, for consistency (ampproject#18304)"

This reverts commit 9b58f86.

* Revert "Change "whitelisted" to "white listed" (ampproject#18301)"

This reverts commit 425cf9f.

* Revert "Fix spelling issue in product page source (ampproject#18302)"

This reverts commit 61c7a2a.

* Revert "鉁↖mplement Scroll App connect flow for Safari (ampproject#17987)"

This reverts commit 2b04e46.

* Revert "Changed i18n to internationalization (ampproject#18307)"

This reverts commit 34e6e54.

* Revert "fix spelling favour into favor (ampproject#18299)"

This reverts commit 067f0a6.

* Revert "Add fetch for upstream (ampproject#18289)"

This reverts commit e8ada57.

* Revert "Fix typo. (ampproject#18274)"

This reverts commit 4272e32.

* Revert "Improve testing section in "getting-started-e2e.md" (ampproject#17720)"

This reverts commit 146cde4.

* Revert "Unskip amp-brid-player tests ampproject#14833 (ampproject#17628)"

This reverts commit 3859679.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanorozco alanorozco alanorozco approved these changes

@nainar nainar nainar approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@samjacoby @alanorozco @nainar @googlebot