Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Master feature] Allow tapping on elements in amp-story-grid-layer #16521

Closed
newmuis opened this Issue Jul 2, 2018 · 5 comments

Comments

@newmuis
Copy link
Collaborator

newmuis commented Jul 2, 2018

For any clickable element outside of amp-story-cta-layer, we should show a tooltip that defers the action until after the user has clicked on the tooltip.

Flow diagram depicting the user tapping on a link to get a tooltip with a URL prompting them to go to a site, then clicking again to confirm and navigating to that site

@newmuis newmuis added this to the Prioritized FRs milestone Jul 2, 2018

@newmuis newmuis self-assigned this Jul 2, 2018

@newmuis newmuis added this to Feature Backlog in AMP HTML Project Roadmap via automation Jul 2, 2018

@newmuis newmuis added this to Incoming (Untriaged) in amp-story via automation Jul 2, 2018

@newmuis newmuis moved this from Incoming (Untriaged) to Master Features in amp-story Jul 3, 2018

@newmuis newmuis added this to To do in AMP stories roadmap via automation Jul 3, 2018

@newmuis newmuis removed this from Master Features in amp-story Jul 3, 2018

@newmuis newmuis assigned gmajoulet and unassigned newmuis Jul 3, 2018

@newmuis

This comment has been minimized.

Copy link
Collaborator Author

newmuis commented Jul 3, 2018

/cc @choumx for his expertise with AMP actions and events, which will probably come in handy for this feature.

@newmuis newmuis assigned Enriqe and unassigned gmajoulet Jul 26, 2018

@newmuis newmuis changed the title [Master feature] Allow tapping on elements outside of amp-story-cta-layer [Master feature] Allow tapping on elements in amp-story-grid-layer Jul 26, 2018

@erwinmombay

This comment has been minimized.

Copy link
Member

erwinmombay commented Aug 21, 2018

This is a high priority issue but it hasn't been updated in awhile. @Enriqe Do you have any updates?

@Enriqe

This comment has been minimized.

Copy link
Collaborator

Enriqe commented Aug 21, 2018

We are in design phase for this, implementation should start right after that.

@ampprojectbot

This comment has been minimized.

Copy link
Collaborator

ampprojectbot commented Sep 11, 2018

This is a high priority issue but it hasn't been updated in awhile. @Enriqe Do you have any updates?

@ampprojectbot

This comment has been minimized.

Copy link
Collaborator

ampprojectbot commented Oct 16, 2018

This is a high priority issue but it hasn't been updated in awhile. @Enriqe Do you have any updates?

@Enriqe Enriqe referenced this issue Oct 24, 2018

Merged

✨ Implements tooltip for amp-story #18945

2 of 3 tasks complete

AMP HTML Project Roadmap automation moved this from Next Up to Shipped Nov 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.