Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Master feature] Allow tapping on elements in amp-story-grid-layer #16521

Closed
2 tasks
newmuis opened this issue Jul 2, 2018 · 5 comments
Closed
2 tasks

[Master feature] Allow tapping on elements in amp-story-grid-layer #16521

newmuis opened this issue Jul 2, 2018 · 5 comments
Assignees
@Enriqe
Labels
P1: High Priority Type: Feature Request WG: stories
Projects
AMP HTML Project Roadmap Stories - Roadmap [DEPRECATED]
Milestone
Prioritized FRs

Comments

@newmuis
Copy link
Contributor

newmuis commented Jul 2, 2018 •
edited

For any clickable element outside of amp-story-cta-layer, we should show a tooltip that defers the action until after the user has clicked on the tooltip.

Flow diagram depicting the user tapping on a link to get a tooltip with a URL prompting them to go to a site, then clicking again to confirm and navigating to that site
@newmuis newmuis added this to the Prioritized FRs milestone Jul 2, 2018
@newmuis newmuis self-assigned this Jul 2, 2018
@newmuis newmuis added this to Feature Backlog in AMP HTML Project Roadmap via automation Jul 2, 2018
@newmuis newmuis mentioned this issue Jul 2, 2018
Closed
@newmuis newmuis added this to Incoming (Untriaged) in Stories - By Type via automation Jul 2, 2018
@newmuis newmuis moved this from Incoming (Untriaged) to Master Features in Stories - By Type Jul 3, 2018
@newmuis newmuis added this to To do in Stories - Roadmap [DEPRECATED] via automation Jul 3, 2018
@newmuis newmuis removed this from Master Features in Stories - By Type Jul 3, 2018
@newmuis newmuis assigned gmajoulet and unassigned newmuis Jul 3, 2018
@newmuis
Copy link
Contributor Author

newmuis commented Jul 3, 2018 •
edited

/cc @choumx for his expertise with AMP actions and events, which will probably come in handy for this feature.

@newmuis newmuis mentioned this issue Jul 11, 2018
Closed
@newmuis newmuis assigned Enriqe and unassigned gmajoulet Jul 26, 2018
@newmuis newmuis changed the title [Master feature] Allow tapping on elements outside of amp-story-cta-layer [Master feature] Allow tapping on elements in amp-story-grid-layer Jul 26, 2018
@erwinmombay
Copy link
Member

This is a high priority issue but it hasn't been updated in awhile. @Enriqe Do you have any updates?

@Enriqe
Copy link
Contributor

Enriqe commented Aug 21, 2018

We are in design phase for this, implementation should start right after that.

@newmuis newmuis mentioned this issue Aug 21, 2018
Closed
@newmuis newmuis moved this from Planned to In Progress in Stories - Roadmap [DEPRECATED] Aug 22, 2018
@ampprojectbot
Copy link
Member

This is a high priority issue but it hasn't been updated in awhile. @Enriqe Do you have any updates?

@Enriqe Enriqe mentioned this issue Sep 18, 2018
Merged
@ampprojectbot
Copy link
Member

This is a high priority issue but it hasn't been updated in awhile. @Enriqe Do you have any updates?

@Enriqe Enriqe mentioned this issue Oct 24, 2018
Merged
3 tasks
AMP HTML Project Roadmap automation moved this from Next Up to Shipped Nov 7, 2018
Stories - Roadmap [DEPRECATED] automation moved this from In Progress to Done Nov 7, 2018
@newmuis newmuis mentioned this issue Nov 9, 2018
Closed
@Enriqe Enriqe mentioned this issue Nov 9, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Enriqe Enriqe

Labels
P1: High Priority Type: Feature Request WG: stories
Projects
AMP HTML Project Roadmap
  
Shipped
Stories - Roadmap [DEPRECATED]
Done
Milestone
Prioritized FRs
Development

No branches or pull requests
6 participants
@erwinmombay @gmajoulet @newmuis @jasti @Enriqe @ampprojectbot