Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Master feature] Increase component support for Stories #16522

Open
newmuis opened this Issue Jul 2, 2018 · 7 comments

Comments

@newmuis
Copy link
Collaborator

commented Jul 2, 2018

Currently <amp-story> supports few AMP elements as descendants. We should improve the component support for stories. There are over 100 AMP components, but they can be broken down into only ~10 buckets of work to support the vast majority of them. By grouping these components by their intended user experience, we can greatly improve the support for these components, and help make AMP Stories feel more like it is a part of the AMP ecosystem.

Legend

Status Description
LAUNCHED This component is generally available for use within amp-story.
ROLLING OUT This component will be generally available for use within amp-story within the next few releases
IMPLEMENTATION This component is currently being implemented for use with amp-story.
IN DESIGN The integration for this component with amp-story is currently being designed.
NOT STARTED The work has not yet begun to design or implement this component's integration with amp-story.
REPLACED This component cannot be used within amp-story, but similar functionality is provided by another component.
UNSUPPORTED This component cannot be used within amp-story.

List of desired components

Last updated Nov. 27, 2018

Launched Components

TBD

Component Status Issue Notes
amp-analyticsLAUNCHED
amp-audioLAUNCHED
amp-call-trackingLAUNCHED
amp-date-countdownLAUNCHED#19427
amp-dynamic-css-classesLAUNCHED
amp-fit-textLAUNCHED
amp-fontLAUNCHED
amp-geoLAUNCHED
amp-story-auto-adsLAUNCHED
amp-timeagoLAUNCHED#19427
amp-videoLAUNCHED

video-interface videos

These videos will autoplay when shown in the story, but may still have player chrome shown in the user interface, depending on the options made available by the third party player API.

Component Status Issue Notes
amp-3q-playerIN DESIGN#15847
amp-brid-playerIN DESIGN#15847
amp-brightcoveIN DESIGN#15847
amp-dailymotionIN DESIGN#15847
amp-gfycatIN DESIGN#15847
amp-ima-videoIN DESIGN#15847
amp-mowplayerIN DESIGN#15847
amp-nexxtv-playerIN DESIGN#15847
amp-ooyala-playerIN DESIGN#15847
amp-video-iframeIN DESIGN#15847
amp-vimeoIN DESIGN#15847
amp-viqeo-playerIN DESIGN#15847
amp-wistia-playerIN DESIGN#15847
amp-youtubeIN DESIGN#15847

Other media players/viewers

TBD

Component Status Issue Notes
amp-3d-gltfIN DESIGN#19213
amp-izleseneIN DESIGN#19213
amp-jwplayerIN DESIGN#19213
amp-kaltura-playerIN DESIGN#19213
amp-o2-playerIN DESIGN#19213
amp-powr-playerIN DESIGN#19213
amp-reach-playerIN DESIGN#19213
amp-soundcloudIN DESIGN#19213
amp-springboard-playerIN DESIGN#19213

Interactive third-party content

TBD

Component Status Issue Notes
amp-beopinionIMPLEMENTATION#19213
amp-bodymovin-animationIN DESIGNTBDCan be made to implement the video-interface for easier implementation
amp-byside-contentIMPLEMENTATION#19213
amp-embedly-cardIMPLEMENTATION#19213
amp-facebook-commentsIMPLEMENTATION#19213
amp-facebook-likeNOT STARTEDTBDShould be allowed in amp-story-cta-layer, not blocked
amp-facebook-pageIMPLEMENTATION#19213
amp-facebookIMPLEMENTATION#19213
amp-gistIMPLEMENTATION#19213
amp-google-document-embedIN DESIGNTBDMakes most sense in a swipe-up context
amp-google-vrview-imageIN DESIGNTBD
amp-huluIMPLEMENTATION#19213
amp-image-sliderIMPLEMENTATION#19213
amp-imgurIMPLEMENTATION#19213
amp-instagramIMPLEMENTATION#19213
amp-mathmlIN DESIGNTBDNon-interactive/readonly
amp-pinterestIMPLEMENTATION#19213
amp-playbuzzIMPLEMENTATION#19213
amp-redditIMPLEMENTATION#19213
amp-riddle-quizIMPLEMENTATION#19213
amp-twitterIMPLEMENTATION#19213
amp-vineIMPLEMENTATION#19213
amp-vkIMPLEMENTATION#19213
amp-yotpoIMPLEMENTATION#19213

Paywalls

TBD

Component Status Issue Notes
amp-access-laterpayIMPLEMENTATION#12180
amp-access-scrollIMPLEMENTATION#12180
amp-accessIMPLEMENTATION#12180
amp-subscriptions-googleIMPLEMENTATION#12180
amp-subscriptionsIMPLEMENTATION#12180

Live blogging & dynamic content

TBD

Component Status Issue Notes
amp-install-serviceworkerIMPLEMENTATION#18742
amp-listNOT STARTEDTBDNeed to allow template tag
amp-live-listNOT STARTED#18624Should be allowed as direct descendant of amp-story, to populate new pages
amp-mustacheNOT STARTEDTBD
amp-web-pushNOT STARTED#18624Should be allowed as direct descendant of amp-story

Forms

TBD

Component Status Issue Notes
amp-date-pickerIN DESIGNTBD
amp-formIN DESIGNTBD
amp-recaptcha-inputNOT STARTEDTBD
amp-selectorIN DESIGNTBD

Animations

TBD

Component Status Issue Notes
amp-animationNOT STARTEDTBD
amp-fx-collectionREPLACED (by amp-story animations)N/A
amp-fx-flying-carpetUNSUPPORTEDN/A

Lightboxes

TBD

Component Status Issue Notes
amp-image-lightboxNOT STARTEDTBD
amp-lightbox-galleryNOT STARTEDTBD
amp-lightboxREPLACED (by amp-story-page-attachment)N/A

Miscellaneous

The remaining components will be considered/implemented on a component-by-component basis.

Component Status Issue Notes
amp-carouselNOT STARTEDTBD"type" attribute must not be "carousel"
amp-experimentNOT STARTEDTBDShould be allowed as direct child of amp-story
amp-next-pageNOT STARTEDTBDWill have a story-specific primitive for next/previous stories
amp-sidebarIMPLEMENTATION#16532
amp-skimlinksNOT STARTEDTBD
Other components Last updated Nov. 7, 2018

Advertising

Advertising in stories is handled through story ads, which are launched. As such, other advertising components are not used within stories.

Component Status Issue Notes
amp-a4aREPLACED (by story ads)#12381
amp-ad-customREPLACED (by story ads)#12381
amp-ad-exitREPLACED (by story ads)#12381
amp-ad-network-adsense-implREPLACED (by story ads)#12381
amp-ad-network-adzerk-implREPLACED (by story ads)#12381
amp-ad-network-cloudflare-implREPLACED (by story ads)#12381
amp-ad-network-doubleclick-implREPLACED (by story ads)#12381
amp-ad-network-fake-implREPLACED (by story ads)#12381
amp-ad-network-gmossp-implREPLACED (by story ads)#12381
amp-ad-network-triplelift-implREPLACED (by story ads)#12381
amp-adREPLACED (by story ads)#12381
amp-auto-adsREPLACED (by story ads)#12381
amp-sticky-adREPLACED (by story ads)#12381

Social sharing

TBD

Component Status Issue Notes
amp-addthisREPLACED (by story sharing options)N/A
amp-share-trackingUNSUPPORTEDN/ANot implemented
amp-social-shareREPLACED (by story sharing options)N/A

User consent

amp-story-consent handles all user consent for stories, including integrating with amp-geo.

Component Status Issue Notes
amp-consentREPLACED (by amp-story-consent)#14538
amp-user-notificationREPLACED (by amp-story-consent)#14538

Interaction handlers

TBD

Component Status Issue Notes
amp-orientation-observerUNSUPPORTEDN/A
amp-pan-zoomUNSUPPORTEDN/A
amp-position-observerUNSUPPORTEDN/A

Miscellaneous

The remaining components will be considered/implemented on a component-by-component basis.

Component Status Issue Notes
amp-accordionUNSUPPORTEDN/A
amp-animUNSUPPORTEDN/APrefer videos (for performance reasons)
amp-apester-mediaUNSUPPORTEDN/A
amp-app-bannerUNSUPPORTEDN/A
amp-bindUNSUPPORTEDN/A
amp-gwd-animationUNSUPPORTEDN/A
amp-iframeUNSUPPORTEDN/APartial support by using amp-story swipe up feature (#15845)
amp-scriptUNSUPPORTEDN/A
amp-slidesUNSUPPORTEDN/ADeprecated
amp-storyUNSUPPORTEDN/AInfinite recursion
amp-viz-vegaUNSUPPORTEDN/AExperimental

@newmuis newmuis added this to the Prioritized FRs milestone Jul 2, 2018

@newmuis newmuis added this to Feature Backlog in AMP HTML Project Roadmap via automation Jul 2, 2018

@newmuis newmuis added this to Incoming (Untriaged) in amp-story via automation Jul 2, 2018

@newmuis newmuis self-assigned this Jul 2, 2018

@newmuis newmuis moved this from Incoming (Untriaged) to Master Features in amp-story Jul 3, 2018

@newmuis newmuis added this to To do in AMP stories roadmap via automation Jul 3, 2018

@newmuis newmuis removed this from Master Features in amp-story Jul 3, 2018

@newmuis newmuis added this to Incoming (Untriaged) in amp-story via automation Jul 27, 2018

@newmuis newmuis removed this from Next Up in AMP HTML Project Roadmap Jul 27, 2018

@newmuis newmuis removed this from Planned in AMP stories roadmap Jul 27, 2018

@erwinmombay

This comment has been minimized.

Copy link
Member

commented Aug 21, 2018

This is a high priority issue but it hasn't been updated in awhile. @newmuis Do you have any updates?

@Enriqe

This comment has been minimized.

Copy link
Collaborator

commented Aug 21, 2018

Work for this will start right after #16521, which is in design phase at the moment.

@ampprojectbot

This comment has been minimized.

Copy link
Collaborator

commented Sep 11, 2018

This is a high priority issue but it hasn't been updated in awhile. @newmuis Do you have any updates?

1 similar comment
@ampprojectbot

This comment has been minimized.

Copy link
Collaborator

commented Oct 16, 2018

This is a high priority issue but it hasn't been updated in awhile. @newmuis Do you have any updates?

@newmuis newmuis moved this from Incoming (Untriaged) to Master Features in amp-story Nov 16, 2018

@newmuis newmuis added this to Planned in AMP stories roadmap via automation Nov 16, 2018

@newmuis newmuis removed this from Master Features in amp-story Nov 16, 2018

@ampprojectbot

This comment has been minimized.

Copy link
Collaborator

commented Jan 9, 2019

This is a high priority issue but it hasn't been updated in awhile. @newmuis Do you have any updates?

@ampprojectbot

This comment has been minimized.

Copy link
Collaborator

commented Feb 13, 2019

This is a high priority issue but it hasn't been updated in awhile. @newmuis Do you have any updates?

@newmuis

This comment has been minimized.

Copy link
Collaborator Author

commented Feb 13, 2019

Lowering the priority of this; this issue covers dozens of components and will not be completed in a timely manner. For priority of specific components' implementations, see the issue linked in the "Issue" column for that component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.