Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Master feature] Support video-interface videos in amp-story #15847

Closed
newmuis opened this issue Jun 5, 2018 · 13 comments
Closed

[Master feature] Support video-interface videos in amp-story #15847

newmuis opened this issue Jun 5, 2018 · 13 comments

Comments

@newmuis
Copy link
Contributor

newmuis commented Jun 5, 2018

Right now, the only video player supported is <amp-video>; we should also support other video interface players like <amp-youtube> or <amp-dailymotion>, etc.

Those that have controls can be opened in a lightbox, once #16521 is completed.

Screen capture of a video being opened in a lightbox from a story

@newmuis newmuis added this to the Backlog Bugs milestone Jun 5, 2018
@newmuis newmuis self-assigned this Jun 5, 2018
@newmuis newmuis added this to Incoming (Untriaged) in Stories - By Type via automation Jun 5, 2018
@newmuis newmuis moved this from Incoming (Untriaged) to Integrations in Stories - By Type Jun 5, 2018
@alanorozco
Copy link
Member

Playback UI may get in the way. There's no way to force UI to not be rendered on most 3p players, unfortunately.

@newmuis
Copy link
Contributor Author

newmuis commented Jun 6, 2018

Yep, we're devising a user experience around this as well. Will likely not be (generally) usable as the background of a page, but can be used as block elements within a page.

@newmuis newmuis changed the title Support video-interface videos in amp-story [Master feature] Support video-interface videos in amp-story Jul 2, 2018
@newmuis newmuis added this to Feature Backlog in AMP HTML Project Roadmap via automation Jul 2, 2018
@newmuis newmuis moved this from Integrations to Master Features in Stories - By Type Jul 3, 2018
@newmuis newmuis added this to To do in Stories - Roadmap [DEPRECATED] via automation Jul 3, 2018
@newmuis newmuis removed this from Master Features in Stories - By Type Jul 3, 2018
@newmuis newmuis added this to Incoming (Untriaged) in Stories - By Type via automation Jul 27, 2018
@newmuis newmuis removed this from Next Up in AMP HTML Project Roadmap Jul 27, 2018
@newmuis newmuis removed this from Planned in Stories - Roadmap [DEPRECATED] Jul 27, 2018
@erwinmombay
Copy link
Member

This is a high priority issue but it hasn't been updated in awhile. @newmuis Do you have any updates?

@newmuis
Copy link
Contributor Author

newmuis commented Aug 21, 2018

The design and implementation of this has been deferred until later, as we figure out the best way to allow landscape-oriented content in the format.

@newmuis newmuis moved this from Incoming (Untriaged) to Master Features in Stories - By Type Nov 16, 2018
@newmuis newmuis added this to Planned in Stories - Roadmap [DEPRECATED] via automation Nov 16, 2018
@newmuis newmuis removed this from Master Features in Stories - By Type Nov 16, 2018
@ampprojectbot
Copy link
Member

This issue hasn't been updated in awhile. @newmuis Do you have any updates?

@newmuis
Copy link
Contributor Author

newmuis commented Nov 30, 2018

The first step is fixing the way MediaPool interacts with the components it manages (#13673), then we can figure out how to potentially manage iframe-based components containing videos with MediaPool.

@alanorozco
Copy link
Member

With tap-to-watch, is there a need for MediaPool at all? I don't think think the signals to bless would work asynchronously (i.e. via postMessage).

@newmuis
Copy link
Contributor Author

newmuis commented Dec 3, 2018

With tap-to-watch, is there a need for MediaPool at all?

Correct, we wouldn't need it for that.

I don't think think the signals to bless would work asynchronously (i.e. via postMessage).

Also correct.

However, I think (if possible), we want to allow autoplaying these videos. We'd want to prototype and figure out whether this is even technically possible.

@spinmar
Copy link

spinmar commented Dec 11, 2018

@newmuis When do you think this feature will be released? I'm interested too.

@newmuis
Copy link
Contributor Author

newmuis commented Dec 19, 2018

@spinmar We are planning on looking at this over the course of the next three months or so. It is dependent on both the ability to expand components (#19213), as well as the media refactor we're doing (#13673), plus the other custom work tracked by this issue, to handle video playback from video interface players like amp-youtube.

The best way to keep up-to-date is by subscribing to this GitHub issue, which is where updates on this feature will be posted.

@kalwalt
Copy link

kalwalt commented Jan 7, 2019

I tried to add amp-youtube into my amp story but i discovered after, that is not supported ATM. I will follow this issue, thank you. 👍

@stale
Copy link

stale bot commented Jun 30, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Inactive for one year or more label Jun 30, 2020
@stale stale bot closed this as completed Jul 7, 2020
Stories - By Type automation moved this from Incoming (Untriaged) to Done Jul 7, 2020
@robin-scott
Copy link

Tentatively poking for web stories via WP - following editorial request for embed of YouTube video.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Stories - By Effort
S (<= 2.5 days)
Development

No branches or pull requests

8 participants