-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Master feature] Support video-interface videos in amp-story #15847
Comments
Playback UI may get in the way. There's no way to force UI to not be rendered on most 3p players, unfortunately. |
Yep, we're devising a user experience around this as well. Will likely not be (generally) usable as the background of a page, but can be used as block elements within a page. |
This is a high priority issue but it hasn't been updated in awhile. @newmuis Do you have any updates? |
The design and implementation of this has been deferred until later, as we figure out the best way to allow landscape-oriented content in the format. |
This issue hasn't been updated in awhile. @newmuis Do you have any updates? |
The first step is fixing the way MediaPool interacts with the components it manages (#13673), then we can figure out how to potentially manage iframe-based components containing videos with MediaPool. |
With tap-to-watch, is there a need for MediaPool at all? I don't think think the signals to bless would work asynchronously (i.e. via |
Correct, we wouldn't need it for that.
Also correct. However, I think (if possible), we want to allow autoplaying these videos. We'd want to prototype and figure out whether this is even technically possible. |
@newmuis When do you think this feature will be released? I'm interested too. |
@spinmar We are planning on looking at this over the course of the next three months or so. It is dependent on both the ability to expand components (#19213), as well as the media refactor we're doing (#13673), plus the other custom work tracked by this issue, to handle video playback from video interface players like The best way to keep up-to-date is by subscribing to this GitHub issue, which is where updates on this feature will be posted. |
I tried to add |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
Tentatively poking for web stories via WP - following editorial request for embed of YouTube video. |
Right now, the only video player supported is
<amp-video>
; we should also support other video interface players like<amp-youtube>
or<amp-dailymotion>
, etc.Those that have controls can be opened in a lightbox, once #16521 is completed.
The text was updated successfully, but these errors were encountered: