New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Master feature] Support video-interface videos in amp-story #15847

Open
newmuis opened this Issue Jun 5, 2018 · 4 comments

Comments

@newmuis
Collaborator

newmuis commented Jun 5, 2018

Right now, the only video player supported is <amp-video>; we should also support other video interface players like <amp-youtube> or <amp-dailymotion>, etc.

Those that have controls can be opened in a lightbox, once #16521 is completed.

Screen capture of a video being opened in a lightbox from a story

@newmuis newmuis added this to the Backlog Bugs milestone Jun 5, 2018

@newmuis newmuis self-assigned this Jun 5, 2018

@newmuis newmuis added this to Incoming (Untriaged) in amp-story via automation Jun 5, 2018

@newmuis newmuis moved this from Incoming (Untriaged) to Integrations in amp-story Jun 5, 2018

@alanorozco

This comment has been minimized.

Show comment
Hide comment
@alanorozco

alanorozco Jun 6, 2018

Member

Playback UI may get in the way. There's no way to force UI to not be rendered on most 3p players, unfortunately.

Member

alanorozco commented Jun 6, 2018

Playback UI may get in the way. There's no way to force UI to not be rendered on most 3p players, unfortunately.

@newmuis

This comment has been minimized.

Show comment
Hide comment
@newmuis

newmuis Jun 6, 2018

Collaborator

Yep, we're devising a user experience around this as well. Will likely not be (generally) usable as the background of a page, but can be used as block elements within a page.

Collaborator

newmuis commented Jun 6, 2018

Yep, we're devising a user experience around this as well. Will likely not be (generally) usable as the background of a page, but can be used as block elements within a page.

@newmuis newmuis changed the title from Support video-interface videos in amp-story to [Master feature] Support video-interface videos in amp-story Jul 2, 2018

@newmuis newmuis added this to Feature Backlog in AMP HTML Project Roadmap via automation Jul 2, 2018

@newmuis newmuis moved this from Integrations to Master Features in amp-story Jul 3, 2018

@newmuis newmuis added this to To do in AMP stories roadmap via automation Jul 3, 2018

@newmuis newmuis removed this from Master Features in amp-story Jul 3, 2018

@newmuis newmuis added this to Incoming (Untriaged) in amp-story via automation Jul 27, 2018

@newmuis newmuis removed this from Next Up in AMP HTML Project Roadmap Jul 27, 2018

@newmuis newmuis removed this from Planned in AMP stories roadmap Jul 27, 2018

@erwinmombay

This comment has been minimized.

Show comment
Hide comment
@erwinmombay

erwinmombay Aug 21, 2018

Member

This is a high priority issue but it hasn't been updated in awhile. @newmuis Do you have any updates?

Member

erwinmombay commented Aug 21, 2018

This is a high priority issue but it hasn't been updated in awhile. @newmuis Do you have any updates?

@newmuis

This comment has been minimized.

Show comment
Hide comment
@newmuis

newmuis Aug 21, 2018

Collaborator

The design and implementation of this has been deferred until later, as we figure out the best way to allow landscape-oriented content in the format.

Collaborator

newmuis commented Aug 21, 2018

The design and implementation of this has been deferred until later, as we figure out the best way to allow landscape-oriented content in the format.

@newmuis newmuis added P2: Soon and removed P1: High Priority labels Aug 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment