✨amp-consent-ui: Improved the CMP amp-consent demo #19992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p-consent-loading-placeholder
…p-consent-loading-placeholder-sync-demo
zhouyx
approved these changes
Dec 19, 2018
zhouyx
suggested changes
Dec 19, 2018
test/manual/diy-consent.html
Outdated
|
|
||
| <h1 class="animated fadeIn">More Information</h1> | ||
| <div class="animated fadeIn"> | ||
| The General Data Protection Regulation (EU) 2016/679 ("GDPR") is a regulation in EU law on data protection and privacy for all individuals within the European Union (EU) and the European Economic Area (EEA). It also addresses the export of personal data outside the EU and EEA areas. The GDPR aims primarily to give control to individuals over their personal data and to simplify the regulatory environment for international business by unifying the regulation within the EU.[1] Superseding the Data Protection Directive 95/46/EC, the regulation contains provisions and requirements pertaining to the processing of personal data of individuals (formally called data subjects in the GDPR) inside the EEA, and applies to an enterprise established in the EEA or—regardless of its location and the data subjects' citizenship—that is processing the personal information of data subjects inside the EEA. |
There was a problem hiding this comment.
Can we remove those and replace with some fake text. I would rather not be explicit incase the text itself is used as template.
|
@zhouyx This is good to go 😄 |
zhouyx
approved these changes
Dec 19, 2018
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* Added the loading placeholder html * Added the svg, and renamed some classes for consistency * Finished styles for the placeholder spinner * Need to stop the height flash/jump thing * Finished up the loading placeholder * Started tests, used htmlFor * Added tests for placeholder * Fixed precommit checks * Added fix for safari on svg * Another safari fix for svg * Made all requested changes * Made requested changes * Made all requested changes * MOdified to get working on tunnel * Fixed iframe container * Fixed the border, some last little css * Reser the app.js to master * Replaced with lorem ipsum text * Fixed tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to #19969
This implements the nicer example demoed to @spacedino . Also, this makes some of the API requests more friendly with development URLs other than localhost 😄 .
Lastly, the CSS from
extensions/amp-consent/0.1/amp-consent.cssis a change to stop the original padding from the non-CMP case, affecting our iframe that is used with the CMP.