New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unmute some performance tests #21062
Comments
I can't reproduce the error myself (here's notes on that), but I understand the problem. Webkit validates the entryTypes passed to a call to perfObserver.observe({entryTypes: ['some', 'entry', 'types']}); If it sees all entryTypes are invalid, it throws a TypeError. This is the case in our tests, where we stub properties on the window object to pretend that APIs like Event Timing exist in order to test the implementation of our metrics collection. Since these APIs don't actually exist and fail this validation, we see the TypeError in Safari. |
* Fix tickevent tests for Safari Fixes #21062 * Add comment to allow legit usage of console.warn * ESLint fix * Use dev() log instead of console * Add import statement * Fix lint
* Fix tickevent tests for Safari Fixes ampproject#21062 * Add comment to allow legit usage of console.warn * ESLint fix * Use dev() log instead of console * Add import statement * Fix lint
* Fix tickevent tests for Safari Fixes ampproject#21062 * Add comment to allow legit usage of console.warn * ESLint fix * Use dev() log instead of console * Add import statement * Fix lint
Muted by #21061
@ericandrewlewis could you pls take a look?
The text was updated successfully, but these errors were encountered: