Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ Skip failing performance test on Safari #21061

Merged
merged 1 commit into from Feb 26, 2019
Merged

✅ Skip failing performance test on Safari #21061

merged 1 commit into from Feb 26, 2019

Conversation

rsimha
Copy link
Contributor

@rsimha rsimha commented Feb 25, 2019 •
edited

This PR addresses #20721 (comment) by skipping the failing tests on Safari only.

https://travis-ci.org/ampproject/amphtml/jobs/498416589#L2353-L2371

Logs for posterity:

DESCRIBE => PeformanceObserver metrics
  DESCRIBE =>  
    DESCRIBE => should forward paint metrics for performance entries
      IT => created before performance service registered
        ✗ entryTypes contained only unsupported types
        observe@[native code]
        registerPerformanceObserver_@/home/travis/build/ampproject/amphtml/src/service/performance-impl.js:233:21 <- /tmp/5502fab4fcfd3899ef4e381a680b0b8b.browserify.js:88542:21
        Performance@/home/travis/build/ampproject/amphtml/src/service/performance-impl.js:115:4 <- /tmp/5502fab4fcfd3899ef4e381a680b0b8b.browserify.js:88419:38
        getServiceInternal@/home/travis/build/ampproject/amphtml/src/service.js:401:23 <- /tmp/5502fab4fcfd3899ef4e381a680b0b8b.browserify.js:77007:23
        /home/travis/build/ampproject/amphtml/test/unit/test-performance.js:745:43 <- /tmp/5502fab4fcfd3899ef4e381a680b0b8b.browserify.js:146239:51

    DESCRIBE => should forward first input metrics for performance entries
      IT => created before performance service registered
        ✗ entryTypes contained only unsupported types
        observe@[native code]
        registerPerformanceObserver_@/home/travis/build/ampproject/amphtml/src/service/performance-impl.js:233:21 <- /tmp/5502fab4fcfd3899ef4e381a680b0b8b.browserify.js:88542:21
        Performance@/home/travis/build/ampproject/amphtml/src/service/performance-impl.js:115:4 <- /tmp/5502fab4fcfd3899ef4e381a680b0b8b.browserify.js:88419:38
        getServiceInternal@/home/travis/build/ampproject/amphtml/src/service.js:401:23 <- /tmp/5502fab4fcfd3899ef4e381a680b0b8b.browserify.js:77007:23
        /home/travis/build/ampproject/amphtml/test/unit/test-performance.js:835:43 <- /tmp/5502fab4fcfd3899ef4e381a680b0b8b.browserify.js:146314:51

With this, hopefully, we should have an all green Sauce Labs Travis job.

@rsimha rsimha self-assigned this Feb 25, 2019
@rsimha
Copy link
Contributor Author

rsimha commented Feb 25, 2019

/to @lannka @estherkim

@lannka lannka mentioned this pull request Feb 25, 2019
Closed
@rsimha rsimha merged commit bb111a6 into ampproject:master Feb 26, 2019
@rsimha rsimha deleted the 2019-02-25-SkipPerformanceTest branch February 26, 2019 00:12
noranazmy pushed a commit to noranazmy/amphtml that referenced this pull request Mar 22, 2019
@rsimha
✅ Skip failing performance test on Safari (ampproject#21061)
0dae827
bramanudom pushed a commit to bramanudom/amphtml that referenced this pull request Mar 22, 2019
@rsimha @bramanudom
✅ Skip failing performance test on Safari (ampproject#21061)
7ea57b8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lannka lannka lannka approved these changes

@estherkim estherkim Awaiting requested review from estherkim

Assignees

@rsimha rsimha

Labels
cla: yes Related to: Flaky Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rsimha @lannka @googlebot