Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Master feature] Support live AMP Stories #21714

Closed
Enriqe opened this issue Apr 4, 2019 · 6 comments · Fixed by #23041
Closed

[Master feature] Support live AMP Stories #21714

Enriqe opened this issue Apr 4, 2019 · 6 comments · Fixed by #23041
Assignees
Labels
INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code P1: High Priority Type: Feature Request WG: stories

Comments

@Enriqe
Copy link
Contributor

Enriqe commented Apr 4, 2019

Enable the creation of live stories. Users will be able view stories that are updated in real-time as the publisher adds new pages to it - without the need of having the user refresh the page. Think live blogging.

This will unblock use cases like:

  • Live sport match reporting (updated scores, commentaries, etc..)
  • Live news coverage
  • Live keynote updates (e.g. reporter using AMP Stories in keynote event)

We’ll use the amp-live-list functionality to make real-time updates to the DOM. Whenever a new page is detected in the source document, we’ll update the client to reflect the changes. These include a UI treatment and internally letting amp-story know that there is a new page.

This master issue will keep track of the subtasks needed to support this feature.

Subtasks

Title

Description

Status

Github Issue

Modify `amp-live-list` to support dynamically added lists and add configuration options We will need this to specify `amp-story` as the new container for dynamic elements, see issue for more details DONE #21718
Listen to updates at the `amp-story` level We will need to listen to the `AmpLiveList#update` method, and take the necessary actions when that happens (i.e. show system button UI, insert page in DOM, update progress bar, etc...) DONE #21719
Show system UI Show a UI treatment when there is a new update in the story. DONE #21721 #22700
Update `amp-story` progress bar Whenever a new page is added to the story, we will need to update the progress bar to reflect that. Our current implementation only builds the progress bar at `AmpStory#layoutCallback` DONE #21722
Pre-launch testing Sanity checking and adding more tests DONE
Launch Enable validation & submit documentation DONE
@siddiqrahman
Copy link

@Enriqe is it working amp-live-list in amp story?

@Enriqe
Copy link
Contributor Author

Enriqe commented Apr 29, 2019

Hi @siddiqrahman, this feature is still in development but you can follow the progress in this issue 👍

@newmuis newmuis added this to Untriaged in Stories - By Effort May 13, 2019
@newmuis newmuis moved this from Untriaged to XL (11+ days) in Stories - By Effort May 13, 2019
@newmuis newmuis added the INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code label May 14, 2019
@ithinkihaveacat
Copy link
Contributor

FYI there are some issues with amp-live-list getting timely update on some caches, see e.g. the Google internal b/124009333.

@Enriqe
Copy link
Contributor Author

Enriqe commented May 14, 2019

Thanks for the heads up @ithinkihaveacat 👍

@Enriqe
Copy link
Contributor Author

Enriqe commented May 29, 2019

Main tasks are now done. Performing sanity checking & closing open discussions. Launching process will follow soon after this.

@Enriqe
Copy link
Contributor Author

Enriqe commented May 30, 2019

Note there is a problem with amp-live-list getting timely updates in the amp cache. #13659

/cc @newmuis

Stories - By Type automation moved this from Incoming (Untriaged) to Done Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
INTENT TO IMPLEMENT Proposes implementation of a significant new feature. https://bit.ly/amp-contribute-code P1: High Priority Type: Feature Request WG: stories
Projects
Stories - By Effort
XL (11+ days)
Development

Successfully merging a pull request may close this issue.

4 participants