Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨Adds button when new update is available #22519

Merged
merged 2 commits into from May 29, 2019

Conversation

Enriqe
Copy link
Contributor

@Enriqe Enriqe commented May 27, 2019

Closes #21721
Master issue: #21714

When button is clicked, user is taken to the latest page in the story.

@gmajoulet
Copy link
Contributor

The code mostly LGTM, but can we check with product/UX/interested publishers that this is the expected behavior before checking in the code?

@Enriqe
Copy link
Contributor Author

Enriqe commented May 28, 2019

Thanks @gmajoulet, this behavior was signed off at the design phase and again at a UX meeting last week :)

EDIT: It's also important to note that the exact UX of the button is still in progress, so we will update it when it's ready. (As noted by the TODO comment in the css file).

@newmuis
Copy link
Contributor

newmuis commented May 28, 2019

Sorry, I'm not sure I understand from reading the code: does clicking the button take you to the last page? or the first of the added pages? I would expect the latter...

@Enriqe
Copy link
Contributor Author

Enriqe commented May 28, 2019

As chatted more offline: it takes you to the last page, because we want to adhere to the amp-live-list behavior, as well as the behavior of most live blogging platforms, which take you to the "latest" entry. UX was also part of this discussion and agreed with this.

@Enriqe Enriqe merged commit d0f56cf into ampproject:master May 29, 2019
@Enriqe Enriqe deleted the new-update-ui branch May 29, 2019 20:20
thekorn pushed a commit to edelight/amphtml that referenced this pull request Sep 11, 2019
* Adds button when new update is available

* renames, delete newlines, vsync.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

LiveStoryManager: Show system button UI for new updates
4 participants