New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨Adds button when new update is available #22519
Conversation
The code mostly LGTM, but can we check with product/UX/interested publishers that this is the expected behavior before checking in the code? |
Thanks @gmajoulet, this behavior was signed off at the design phase and again at a UX meeting last week :) EDIT: It's also important to note that the exact UX of the button is still in progress, so we will update it when it's ready. (As noted by the TODO comment in the css file). |
Sorry, I'm not sure I understand from reading the code: does clicking the button take you to the last page? or the first of the added pages? I would expect the latter... |
As chatted more offline: it takes you to the last page, because we want to adhere to the |
* Adds button when new update is available * renames, delete newlines, vsync.
Closes #21721
Master issue: #21714
When button is clicked, user is taken to the latest page in the story.