✅ Add visual tests for live story notification label #22813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also add tests for RTL? |
gmajoulet
reviewed
Jun 13, 2019
|
PTAL. |
gmajoulet
approved these changes
Jun 13, 2019
|
Side note: having more tests is always good, but I find it a bit extreme to have 12 screenshots and 3 new files for a simple toast message with 0 parameterization. If we were to do that for every single feature, our visual diff tests would get really really hard to maintain :( Alternative proposal for the next visual diff tests so this message isn't a useless rant:
|
|
+1 to:
That's behavior, so it seems like a unit test could test this. The visual tests should primarily test the visuals. |
|
I gave it another go, let me know what you think! |
Enriqe
force-pushed
the
live-story-visual-test
branch
from
c74cadf
to
f974b91
Compare
gmajoulet
approved these changes
Jun 13, 2019
newmuis
approved these changes
Jun 13, 2019
|
Could you guys also approve the Percy diffs? Thanks! |
thekorn
pushed a commit
to edelight/amphtml
that referenced
this pull request
Sep 11, 2019
* add visual tests for live story notification label * add rtl tests and delete duplicate desktop test * do rtl in same test, remove rtl file, remove behavior logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial for #21714
Adds visual tests for live story notification label, it mocks when a new page is added.