Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<amp-carousel> is animating cards while user is scrolling in iOS 13 beta (Safari, Chrome & Firefox) #24541

Closed
sirceljm-celtra opened this issue Sep 16, 2019 · 18 comments · Fixed by #24771

Comments

@sirceljm-celtra
Copy link

sirceljm-celtra commented Sep 16, 2019

What's the issue?

If user is scrolling on the AMP page which includes an <amp-carousel>, then the carousel will switch between cards while scrolling.

If "autoplay" is set on the carousel then the carousel will be animating indefinitely while scrolling. If "autoplay" is not set, then the carousel will animate back to the first card and stay there.

How do we reproduce the issue?

Open the following AMP page in any browser in iOS13 beta on an iPhone or iPad.

<!doctype html>
<html ⚡>
<head>
<meta charset="utf-8">
  <title>amp-carousel</title>
  <script async src="https://cdn.ampproject.org/v0.js"></script>
  <script async custom-element="amp-carousel" src="https://cdn.ampproject.org/v0/amp-carousel-0.1.js"></script>
  <link rel="canonical" href="https://amp.dev/documentation/examples/components/amp-carousel/index.html">
  <meta name="viewport" content="width=device-width,minimum-scale=1,initial-scale=1">
</head>
<body>
  <amp-carousel width="400" height="300" layout="responsive" type="slides" autoplay delay="2000">
    <amp-img src="https://playground.amp.dev/static/samples/img/image1.jpg" width="400" height="300" layout="responsive" alt="a sample image"></amp-img>
    <amp-img src="https://playground.amp.dev/static/samples/img/image2.jpg" width="400" height="300" layout="responsive" alt="another sample image"></amp-img>
    <amp-img src="https://playground.amp.dev/static/samples/img/image3.jpg" width="400" height="300" layout="responsive" alt="and another sample image"></amp-img>
  </amp-carousel>
</body></html>

When scrolling the page the carousel will animate between cards very fast.

What browsers are affected?

All browsers on iOS13 beta

Which AMP version is affected?

Latest

@itsmsc
Copy link

itsmsc commented Sep 23, 2019

The problem still exists in the iOS 13 - release version. In my opinion is this a serious UI - issue

@meistudioli
Copy link
Contributor

I have some problem too.

demo: https://blog.lalacube.com/mei/yahoo_mall_fp_amp.php

image

@tanakayuki
Copy link

I'm seeing the same symptoms
Occurs even when “autoplay” is not set in the amp-carousel
, can confirm this bug in iOS(+13)

@sparhami
Copy link

I created a demo page to reproduce the issue with amp-carousel 0.1:

https://output.jsbin.com/qujeqah/1

Swiping to the second or third slide, then swiping down causes the carousel to go back to the first slide. A page with amp-carousel 0.2 does not see the same issue:

https://output.jsbin.com/hudalit/1

@itsmsc
Copy link

itsmsc commented Sep 25, 2019

You can see the problem on one of our pages: https://www.mdr.de/tv/index~amp.html
Both problems, described on the first entry; If "autoplay" is set on the carousel then the carousel will be animating indefinitely while scrolling. If "autoplay" is not set, then the carousel will animate back to the first card and stay there.
Please fix this contemporary!

@joshcp
Copy link

joshcp commented Sep 25, 2019

Two additional examples:

@itsmsc
Copy link

itsmsc commented Sep 26, 2019

A page with amp-carousel 0.2 does not see the same issue:

https://output.jsbin.com/hudalit/1

I can confirm that amp-carousel 0.2 does not see the same issue. I have migrate all pages to v 0.2 with some CSS - changes. This works for me. Thank you.

@tanakayuki
Copy link

tanakayuki commented Sep 26, 2019

I can confirm that the same issue has been fixed by changing to amp-carousel 0.2

Thank you!!

@conwaydev
Copy link

conwaydev commented Sep 27, 2019

Noticed this issue this morning with type="slides" and autoplay. This is a pretty big accessibility issue.

Screen Recording 2019-09-27 at 10 51 AM

@joshcp
Copy link

joshcp commented Sep 27, 2019

Thanks @sparhami - will this fix go live Tuesday? Or, what's the timeline?

@sparhami
Copy link

Thanks @sparhami - will this fix go live Tuesday? Or, what's the timeline?

The normal release process would be that this will be in the next canary on Tuesday, which will go live one week after that. I will look into cherry-picking this into production however, since this does seem like it causes quite a few problems. Hopefully that can be done today or Monday.

@7110
Copy link

7110 commented Oct 7, 2019

@sparhami
I think this amp-carousel bug #24844 which is not been cured yet by #24771 .
amp-carousel will go next even when scrolling in the X-axis Y-axis direction.

http://hml.vivo4g.clientes.ananke.com.br/videos/erro-carousel-iphone2.webm

iOS 13.1.2 Safari (iPhone7, iPhoneX, etc...)
(used dist/v0/amp-carousel-0.1.js which pulled the latest master branch and generated by gulp dist)

Please check this bug 🙇🙇🙇

@ThongSaltire
Copy link

Confirmed! This bug is still existed with current amp-carousel version

@sparhami
Copy link

While the bug has been fixed in the code, it is not live yet. The fix will hopefully be present in the next canary version. The releases Slack channel is updated whenever a new canary is cut and when a canary is promoted to production.

@acsant
Copy link

acsant commented Oct 15, 2019

SwipeCarouselBug

Should this issue be re-opened? I'm still noticing this bug, but only when scroll after swiping out of the full screen in the new carousel v0.2

@sparhami
Copy link

@acsant To keep the issues separate and easy to follow, please file a new bug for amp-carousel 0.2.

@Aeakanshi
Copy link

We have also faced the same scrolling issue in ios devices.

@Aeakanshi
Copy link

For the Scroll function use this CSS code, it works

{
overflow-y: scroll;
-webkit-overflow-scrolling: touch;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.