Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<amp-beopinion>does not work in <amp-story-page-attachment> #24672

Closed
mufaddal7 opened this issue Sep 21, 2019 · 4 comments · Fixed by #24673
Closed

<amp-beopinion>does not work in <amp-story-page-attachment> #24672

mufaddal7 opened this issue Sep 21, 2019 · 4 comments · Fixed by #24673

Comments

@mufaddal7
Copy link

mufaddal7 commented Sep 21, 2019

What's the issue?

<amp-beopinion> does not work in <amp-story-page-attachment>

How do we reproduce the issue?

<amp-story-page id="page1">
<amp-story-page-attachment layout="nodisplay">
                <h1>Vote Now</h1>
                <amp-beopinion width=375 height=472
                               layout="responsive"
                               data-account="5d85e66f46e0fb00019f4e68"
                               data-content="5d85e77f46e0fb00019f5837"
                               data-name="content-slot">
                </amp-beopinion>
            </amp-story-page-attachment>
        </amp-story-page>

Upload this code in a story

Solution

@BeOpinion Needs to change the style of the iframe to display:block from display:flex

Working in this image 1
image

Not working in the existing setting
image

@bloodyowl
Copy link
Contributor

@mufaddal7 thanks for the bug report! I opened a PR with a fix to your issue.

@mufaddal7
Copy link
Author

There has been a temporary solution provided by the Beop team (Message by Beop team)
I have validated the issue and it seems to be solved currently, however it works very slow and is spoiling the user experience and the UI also seems to be poor for AMP Stories

@gmajoulet gmajoulet self-assigned this Sep 24, 2019
@gmajoulet gmajoulet added this to Incoming (Untriaged) in Stories - By Type via automation Sep 24, 2019
@gmajoulet gmajoulet added this to Untriaged in Stories - By Effort via automation Sep 24, 2019
@gmajoulet
Copy link
Contributor

Could you post more information about how to reproduce this issue? Was it on any specific browser, or with any specific CSS?

On a story with no CSS and on Chrome, your snippet seems to work:

image

@bloodyowl
Copy link
Contributor

@gmajoulet we (BeOp) added a temporary workaround on our side while #24673 is pending

Stories - By Type automation moved this from Incoming (Untriaged) to Done Sep 26, 2019
sparhami pushed a commit that referenced this issue Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

3 participants