Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

馃悰 Fix BeOp's style issue with flex #24673

Merged
merged 1 commit into from Sep 26, 2019

Conversation

bloodyowl
Copy link
Contributor

Closes #24672

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

馃摑 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

鈩癸笍 Googlers: Go here for more info.

@bloodyowl
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

鈩癸笍 Googlers: Go here for more info.

@gmajoulet gmajoulet requested review from gmajoulet and removed request for gmajoulet September 24, 2019 18:40
@gmajoulet
Copy link
Contributor

cc @ampproject/wg-ui-and-a11y

@sparhami
Copy link

This change looks fine to me, but I'm not sure why it was display flex to begin with, and what situations it made a difference. It is also unclear what the layout issue was.

It looks like the beopinion code now sets the display to block it a setTimeout loop continuously. which is definitely not good. This seems to be the workaround referenced in the issue.

Stuff seems to be centered, though that may be due to additional code changes on their side to replace the original flex on the container element.

@@ -74,9 +74,7 @@ function createContainer(global, data) {

setStyles(container, {
width: '100%',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove the width: '100%', it is redundant with display: block.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might be better to keep it in cases it's contained in a flex element. the iframe we inject inside uses a width: 1px; min-width: 100% trick due to a iOS bug.

Screenshot 2019-09-26 at 11 39 50

Screenshot 2019-09-26 at 11 40 01

@sparhami sparhami merged commit 99a272d into ampproject:master Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

<amp-beopinion>does not work in <amp-story-page-attachment>
4 participants