New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
馃悰 Fix BeOp's style issue with flex #24673
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 馃摑 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
鈩癸笍 Googlers: Go here for more info. |
@googlebot I signed it! |
CLAs look good, thanks! 鈩癸笍 Googlers: Go here for more info. |
cc @ampproject/wg-ui-and-a11y |
This change looks fine to me, but I'm not sure why it was display flex to begin with, and what situations it made a difference. It is also unclear what the layout issue was. It looks like the beopinion code now sets the display to Stuff seems to be centered, though that may be due to additional code changes on their side to replace the original flex on the container element. |
@@ -74,9 +74,7 @@ function createContainer(global, data) { | |||
|
|||
setStyles(container, { | |||
width: '100%', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can remove the width: '100%'
, it is redundant with display: block
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Closes #24672