-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[amp-story-player] Player should allow scrolling when possible #28009
Comments
Hey, thanks for the report and example! I'm trying to think of a good approach to solve for this use case. Perhaps allowing vertical scroll events via a url param that the iframe host sets. There are some complications with this, though: e.g. when there is a Some iframe-based components in the wild solve this by introducing two-finger swipes. e.g. if you want to interact with a Google Maps embed in a website, you have to use two-fingers. Otherwise it defaults to scrolling. We could think of doing something similar for swipe-up, and add an education banner that prompts the user to use two fingers to interact with the swipe up. Just an initial thought. @gmajoulet do you have any thoughts around this? /cc @ampproject/wg-stories |
There are a lot of precedents for this kind of issue, brought to us by years of carousel components trends :)) The biggest issue I see on the page you linked to, is that on swipe up nothing interesting happens: the page does not scroll, and the story does nothing interesting (the tap back tap next education is irrelevant to what the user is trying to do). I believe the Story should behave just like a scrollable
I'm not 100% sure how to implement this but we can start looking into it. We have various viewer messaging things to handle touch events or check if the current page has a page attachment. |
Awesome, |
FYI we've received a couple reports of this for the WordPress editor so far:
My 2c:
Not sure if this was already suggested/discussed. /cc @raovs @hongcatlover |
I can look into this soon. I don't think the "touch to full-screen mode" is a good default though, since we don't really have context on where the player is embedded or what it would take to make it actually go "full screen". I do think that #28009 (comment) is a good start though. WDYT @raovs @hongcatlover ? |
It would have to be publisher-configurable. But yea, let's fix the scrolling issue first. |
+1 to Publisher configured fullscreen / lightbox mode (pull @hongcatlover in if you need UX) If the publisher wants the content to be consumed within the embed we can do a few things:
|
I saw a use case where amp story can be embedded inside another site using iframe. Now When the user comes to this section he is totally stuck and can't scroll or move. This is because the AMP story tap suggestion restrict him from scrolling
Is there a way to remove tap suggestions when the user accidentally tries to scroll on the amp story?
Example URL https://twimbit.com/company/ on Android chrome browser
The text was updated successfully, but these errors were encountered: