Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ [AMP Story Paywall] Validator changes to launch amp-story-subscriptions #38194

Merged
merged 8 commits into from
Jul 18, 2022
Merged

✨ [AMP Story Paywall] Validator changes to launch amp-story-subscriptions #38194

merged 8 commits into from
Jul 18, 2022

Conversation

ychsieh
Copy link
Contributor

@ychsieh ychsieh commented May 13, 2022

No description provided.

@amp-owners-bot amp-owners-bot bot requested a review from dvoytenko May 13, 2022 00:47
@amp-owners-bot
Copy link

amp-owners-bot bot commented May 13, 2022 •
edited by ampprojectbot
Loading

Hey @newmuis, @gmajoulet, @ampproject/wg-caching! These files were changed:

extensions/amp-story-subscriptions/0.1/test/validator-amp-story-subscriptions.html
extensions/amp-story-subscriptions/0.1/test/validator-amp-story-subscriptions.out
extensions/amp-story-subscriptions/validator-amp-story-subscriptions.protoascii
extensions/amp-story/1.0/test/validator-amp-story-amp-experiment-error.out
extensions/amp-story/1.0/test/validator-amp-story-cta-layer-error.out
extensions/amp-story/validator-amp-story.protoascii

@ychsieh ychsieh requested review from gmajoulet and removed request for dvoytenko May 13, 2022 00:47
banaag
banaag approved these changes May 17, 2022
View reviewed changes
Copy link
Contributor

@banaag banaag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for validator changes.

gmajoulet
gmajoulet reviewed May 20, 2022
View reviewed changes
extensions/amp-story-subscriptions/validator-amp-story-subscriptions.protoascii
attrs: {
name: "description"
mandatory: true
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to add the other supported fields as listed in your documentation, otherwise people can't use them: #38179

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Thanks for the catch.

@ychsieh ychsieh requested a review from gmajoulet June 1, 2022 21:09
@gmajoulet gmajoulet added this to In progress in wg-stories Sprint via automation Jun 2, 2022
@ychsieh ychsieh mentioned this pull request Jun 11, 2022
Merged
@ychsieh ychsieh merged commit 7636eb2 into ampproject:main Jul 18, 2022
wg-stories Sprint automation moved this from In progress to Done Jul 18, 2022
@ampprojectbot
Copy link
Member

Warning: disparity between this PR Percy build and its main build

The Percy build for this PR was approved (either manually by a member of the AMP team, or automatically if there were no visual diffs). However, during a continuous integration step we generated another Percy build using the commit on the main branch that this PR was merged into, and there appears to be a mismatch between the two.

This is possibly an indication of an issue with this pull request, but could also be the result of flakiness. Please inspect the two builds < This PR's Percy build / main commit's Percy build > and determine further action:

  • If the disparity appears to be caused by this PR, please create an bug report or send out a new PR to fix
  • If the disparity appears to be a flake, please @-mention ampproject/wg-approvers in a comment
  • If there is no disparity and this comment was created by mistake, please @-mention ampproject/wg-infra
  • If unsure, @-mention ampproject/wg-approvers

jpettitt pushed a commit to jpettitt/amphtml that referenced this pull request Jul 20, 2022
@ychsieh @jpettitt
✨ [AMP Story Paywall] Validator changes to launch amp-story-subscript…
fcd8df3 
…ions (ampproject#38194)

* amp-story-subscriptions doc

* merge

* validator test

* Add optional attributes
@ychsieh ychsieh mentioned this pull request Jul 20, 2022
Closed
jpettitt pushed a commit to jpettitt/amphtml that referenced this pull request Jul 21, 2022
@ychsieh @jpettitt
✨ [AMP Story Paywall] Validator changes to launch amp-story-subscript…
0f098c1 
…ions (ampproject#38194)

* amp-story-subscriptions doc

* merge

* validator test

* Add optional attributes
@jshamble jshamble mentioned this pull request Aug 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmajoulet gmajoulet gmajoulet approved these changes

@banaag banaag banaag approved these changes

Assignees
No one assigned
Labels
PR use: In Beta / Experimental PR use: In LTS PR use: In Stable WG: caching
Projects
wg-stories Sprint
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ychsieh @ampprojectbot @gmajoulet @banaag