✨ Add amp-story-subscriptions experiment and turn it to 100%

[ychsieh]

This will be pushed only when all the final approvals from all stakeholders are granted.

[amp-owners-bot]

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story.js

[gmajoulet]

cc @mszylkowski

Should we turn on the experiment instead?

[mszylkowski]

I'd keep the experiment if we at some point might need to turn it off (eg: adding the component breaks all stories with the component and we have to disable the feature through client-side experiments). So for safety, sounds good to have the experiment.

For reference the experiment can be turned on with canary-config.json and prod-config.json (you can reference #38285, 0 means it's disabled and 1 means it's enabled). The client-side experiments are overriden in another repo but that's not necessary now.

[ychsieh]

Cool thanks for the suggestion! Done.

[newmuis]

Let's be sure to coordinate with @raovs before launching this experiment

[ychsieh]

Definitely, this and other launch PRs #38179 and #38194 would only be merged once we got all the internal approvals from all the stakeholders.

[mszylkowski]

Approving the changes, feel free to merge when the other conditions are met.

[mszylkowski]

@gmajoulet has OWNERS over the config files so you'll need his approval as well

[gmajoulet]

Shouldn't we launch the experiment from the CDN configuration for instant propagation, vs 10+ days with these config changes?

[ychsieh]

Good question. I guess the other two PRs would be merged the same time as this one after all approvals are granted, so even though we can make this config in almost instantly, the developers would still need to wait for the other two PRs to be able to play with this new feature?

[gmajoulet]

Sounds good! Documentation and validation rollout to production faster. We'll be able to enable the experiment through the CDN configuration a few days after merging validation/doc if we want to save a few days : ))

[ampprojectbot]

Warning: disparity between this PR Percy build and its main build

The Percy build for this PR was approved (either manually by a member of the AMP team, or automatically if there were no visual diffs). However, during a continuous integration step we generated another Percy build using the commit on the main branch that this PR was merged into, and there appears to be a mismatch between the two.

This is possibly an indication of an issue with this pull request, but could also be the result of flakiness. Please inspect the two builds < This PR's Percy build / main commit's Percy build > and determine further action:

• If the disparity appears to be caused by this PR, please create an bug report or send out a new PR to fix
• If the disparity appears to be a flake, please @-mention ampproject/wg-approvers in a comment
• If there is no disparity and this comment was created by mistake, please @-mention ampproject/wg-infra
• If unsure, @-mention ampproject/wg-approvers