Create great looking example pages #62
Assignees
Milestone
Comments
|
@cramforce will work with ed on this this afternoon |
|
closed via #141 |
kristoferbaxter
pushed a commit
to kristoferbaxter/amphtml
that referenced
this issue
Jul 23, 2021
* Add setup method * create separate postMessage method and add setup test * adding support for data-params and querystring * updating tests for data-params * re-adding unit test i accidentally removed * Pass custom config added through amp to player * Use correct import format * updated attribute names * adding code suggestions * Add test coverage and fix formatting * Move test config to above assertation * Update media id and player id for vast ad config * Add cust-params data attribute for ads * testing * Integrate with amp-consent and add custom macros * Lint fixes Co-authored-by: Daniel Lee <daniel.lee9415@gmail.com>
kristoferbaxter
pushed a commit
that referenced
this issue
Sep 9, 2021
* Add JW Player to documentation that applies * Revert "Add JW Player to documentation that applies" This reverts commit 5aeba5a. * Extend AMP Params (#62) * Add setup method * create separate postMessage method and add setup test * adding support for data-params and querystring * updating tests for data-params * re-adding unit test i accidentally removed * Pass custom config added through amp to player * Use correct import format * updated attribute names * adding code suggestions * Add test coverage and fix formatting * Move test config to above assertation * Update media id and player id for vast ad config * Add cust-params data attribute for ads * testing * Integrate with amp-consent and add custom macros * Lint fixes Co-authored-by: Daniel Lee <daniel.lee9415@gmail.com> * Remove bad import * Clean up consentgdpr * Add comment about appending querystring * Clean up from rebase * Remove trailing whitespaces * Remove controls attribute * 📖 [JW8-11873] Update JW Player AMP Docs (#61) Update our amp-jwplayer docs with the new attributes Add amp-jwplayer in the docs where it applies * cleanup rebase * lint fixes Co-authored-by: Zack Haigh <zhaigh@jwplayer.com> Co-authored-by: Daniel Lee <daniel.lee9415@gmail.com>
rbeckthomas
pushed a commit
to rbeckthomas/amphtml
that referenced
this issue
Sep 14, 2021
* Add JW Player to documentation that applies * Revert "Add JW Player to documentation that applies" This reverts commit 5aeba5a. * Extend AMP Params (ampproject#62) * Add setup method * create separate postMessage method and add setup test * adding support for data-params and querystring * updating tests for data-params * re-adding unit test i accidentally removed * Pass custom config added through amp to player * Use correct import format * updated attribute names * adding code suggestions * Add test coverage and fix formatting * Move test config to above assertation * Update media id and player id for vast ad config * Add cust-params data attribute for ads * testing * Integrate with amp-consent and add custom macros * Lint fixes Co-authored-by: Daniel Lee <daniel.lee9415@gmail.com> * Remove bad import * Clean up consentgdpr * Add comment about appending querystring * Clean up from rebase * Remove trailing whitespaces * Remove controls attribute * 📖 [JW8-11873] Update JW Player AMP Docs (ampproject#61) Update our amp-jwplayer docs with the new attributes Add amp-jwplayer in the docs where it applies * cleanup rebase * lint fixes Co-authored-by: Zack Haigh <zhaigh@jwplayer.com> Co-authored-by: Daniel Lee <daniel.lee9415@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is just a ticket for what we discussed. Based on Ed's neutral designs with some public domain images, etc.
The text was updated successfully, but these errors were encountered: