Demo update #141
Demo update #141
Conversation
| <html> | ||
| <head> | ||
| <meta charset="utf-8"> | ||
| <title>AMP #0</title> |
|
Please check the license requirements for the used asset and text. What type of license does this fall under https://commons.wikimedia.org/wiki/Commons:Reusing_content_outside_Wikimedia |
|
text: images used: let me know if there is any issue. thanks. |
| <main role="main"> | ||
| <article> | ||
| <figure> | ||
| <amp-img src="img/Mountfujijapan.jpg" layout="responsive" width="360" placeholder |
There was a problem hiding this comment.
Did you see that we automatically create examples.build that has generated files pointing to the minified version and prod?
You probably need to change the img references to /examples/img
for those to work.
There was a problem hiding this comment.
done. and added to gulpfile:
examplesWithMinifiedJs('demo.amp.html');
|
LGTM Lets hand this and back out before launch based on feedback from OSS. |
|
Did you see the email? Maybe put the images into a dedicated dir with a LICENSE file pointing to where you got this from. |
|
@cramforce yep i did, will do that. thanks for the suggestion. |
|
@cramforce how about the copy? should i move the demo.amp.html into third party? (if so we'll have to tweak the build so it gets picked up, etc) |
|
@cramforce so I'm told since the copy is 100 years old that is ok to use, but since the images are public domain, it means there is no license and we can't use them. I'll go ahead and just use the one image you took a few days ago and add another one that I'll take later if that is ok with you. |
|
@cramforce PTAL. I'll work with Ed further to improve this as well as make new ones (especially the assets part).
|
| @@ -0,0 +1,6 @@ | |||
| !_TAG_FILE_FORMAT 2 /extended format/ | |||
There was a problem hiding this comment.
good catch. was running ctags (jstags) accidentally committed it.
|
Lets have some pretty pictures. The text can just be lorem ipsum. |
|
@cramforce great, i've switched it to lorem ipsum. let me know if the images are in. |
|
@erwinmombay You can just download them from the link. And maybe resize as you need them |
|
@cramforce PTAL
|
|
fixed presubmit |
|
hah, have to submit the fix for the presubmit in another PR or else this will never pass lol |
| <article> | ||
| <figure> | ||
| <amp-img | ||
| src="/examples/img/IMG_20150904_181705@1x.jpg" |
There was a problem hiding this comment.
Maybe give this a semantic name?
There was a problem hiding this comment.
done. renamed to hero.jpg and sea.jpg
|
LGTM |
|
Please update the demo accordingly to the new rules (async, plus extra style tags) |
|
will do |
|
added new style and noscript tags to doc. |
all content from https://commons.wikimedia.org