[amp-sidebar 1.0] [Toolbar] Implemented toolbar's "target" attribute #10126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torch2424
force-pushed
the
sidebar-v1-toolbar-target
branch
from
93ca2b9
to
daba1be
Compare
This fixed missing toolbar element classes within the iframe
torch2424
force-pushed
the
sidebar-v1-toolbar-target
branch
from
6ee01e6
to
8fe474a
Compare
camelburrito
approved these changes
Jun 29, 2017
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Jun 30, 2017
…mpproject#10126) * Implemented toolbar's "target" attribute, with a quick demo * Finished up syncing to latest master * Fixed check-types error * Wrote tests for toolbar target * Fixed linting merge errors * Fixed toolbar class being applied to targets * Cleaned up toolbar buuild logic * Added a comment on some clarification * Fixed the missing ownerDocument on the container This fixed missing toolbar element classes within the iframe * Allowed for having targets within other toolbars * Cleaned up the test manual to look beautiful * Removed unneccasry spacing
This was referenced Jul 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9982
Tested in Chrome, Firefox, and Safari
Example Gif